Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt work around rustc regression #4631

Closed
wants to merge 2 commits into from
Closed

attempt work around rustc regression #4631

wants to merge 2 commits into from

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Apr 29, 2022

Objective

CI is failing because of a rustc bug

Solution

Explicitly write out '_ instead of eliding it

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 29, 2022
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Build-System Related to build systems or continuous integration P-Critical This must be fixed immediately or contributors or users will be severely impacted and removed S-Needs-Triage This issue needs to be labelled labels Apr 29, 2022
@alice-i-cecile
Copy link
Member

Giving this P-Critical, because otherwise CI will fail on everything and we won't be able to merge anything.

The regression in question: rust-lang/rust#96540

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 29, 2022
@mockersf
Copy link
Member

I would rather wait for rust to fix the issue than work around it in Bevy.
If we want a quick fix we can use a nightly from before the issue.

On the rust PR that introduces the issue it was mentioned they either want a quick fix or a revert soon

@alice-i-cecile
Copy link
Member

Regression appears to be addressed! rust-lang/rust#96559

Going to test this out on another PR, and see if that's fixed it for us.

@alice-i-cecile
Copy link
Member

Still failing: https://github.com/bevyengine/bevy/runs/6237109995?check_suite_focus=true. We should try again after the next nightly release.

@BoxyUwU BoxyUwU closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRawMeatball TheRawMeatball TheRawMeatball approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior P-Critical This must be fixed immediately or contributors or users will be severely impacted S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BoxyUwU @alice-i-cecile @mockersf @TheRawMeatball