Remove discriminant symbols. #8546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this was an old, long obsolete behavior. |
|
Rebased to fix merge conflict. r?(@graydon) |
|
Collided with some visitor changes that resulted in a |
Given that bootstrapping and running the testsuite works without exporting discriminant values as global constants, I conclude that they're unused and can be removed.
|
Rebased harder. Hopefully that's the last change in the pipeline that improves the dead code I'm deleting? re-r?(@graydon). |
bors
added a commit
that referenced
this pull request
Aug 21, 2013
Given that bootstrapping and running the testsuite works without exporting discriminant values as global constants, I conclude that they're unused and can be removed.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 24, 2022
[`collapsible_if`] fix typo in code-block kind specifier *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: [`collapsible_if`] fix typo in code-block kind specifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that bootstrapping and running the testsuite works without
exporting discriminant values as global constants, I conclude that
they're unused and can be removed.