Use 64-bit integers to represent discriminants #8504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would have failed on 32-to-64-bit cross-compiles.
|
cc @kemurphy |
| 0x1717171717171717 | ||
| }; | ||
| assert_eq!(expected, V as u64); | ||
| assert_eq!(expected, V as u64); |
There was a problem hiding this comment.
Are the above two lines supposed to be identical?
There was a problem hiding this comment.
Oops. No. One of those is supposed to be C. Nice catch; thanks.
|
|
Current status: aforementioned test breakage was a libuv bug (which affected my desktop but not the bots, or other less chaotic Linux systems), and my new version conflicts with #8546 so I'll wait for that to land before re-pushing. |
|
I'm just going to close this so it's not a source of confusion until the changes it conflicts with land. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 14, 2022
…n, r=flip1995 Add lint to detect `allow` attributes without reason I was considering putting this lint into the pedantic group. However, that would result in countless warnings for existing projects. Having it in restriction also seems good to me 🙃 (And now I need sleep 💤 ) --- changelog: New lint [`allow_lint_without_reason`] (Requires the `lint_reasons` feature) Closes: rust-lang/rust-clippy#8502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for making discriminants not always be int (#1647), but it also makes compiles for a 64-bit target not behave differently with respect to how many bits of discriminants are preserved depending on the build host's word size, which is a nice property to have.
We may want to standardize how to abbreviate "discriminant" in a followup change.