Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #81240

Merged
merged 29 commits into from
Jan 21, 2021
Merged

Rollup of 11 pull requests #81240

merged 29 commits into from
Jan 21, 2021

Commits on Dec 18, 2020

  1. Configuration menu
    Copy the full SHA
    c78bfba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a6014b View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Configuration menu
    Copy the full SHA
    2e049a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2021

  1. Configuration menu
    Copy the full SHA
    2eb4ccd View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Configuration menu
    Copy the full SHA
    4274ba4 View commit details
    Browse the repository at this point in the history
  2. Use heading for std::prelude and not io::prelude

    The heading style for `std::prelude` is to be consistent with the
    headings for `std` and `core`: `# The Rust Standard Library` and
    `# The Rust Core Library`, respectively.
    camelid committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    25a4964 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Visit only terminators when removing landing pads

    No functional changes intended
    tmiasko committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    96e9562 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d829e40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    38b7742 View commit details
    Browse the repository at this point in the history
  4. Fix internal rustdoc broken links

    As it was suggested in rust-lang#81037 `SpecFromIter` is not
    in the scope and therefore (even it should fail),
    we get a warning when we try do document private
    intems in `rust/library/alloc/`.
    
    This fixes rust-lang#81037 by adding the trait in the scope
    and also adding an `allow(unused_imports)` flag so that
    the compiler does not complain, Since the trait is not used
    per se in the code, it's just needed to have properly documented
    docs.
    CPerezz committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    9abd80c View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Remove unnecessary after_run function

    It's called at the same time and in the same place as `after_krate`, so
    they can be combined.
    jyn514 committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    d926147 View commit details
    Browse the repository at this point in the history
  2. Fix typo in counters.rs

    formating -> formatting
    eltociear authored Jan 19, 2021
    Configuration menu
    Copy the full SHA
    203df17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3fb53c2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bc6720f View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Add Vec visualization to understand capacity

    Visualize vector while differentiating between stack and heap.
    
    Inspired by cheats.rs, as this is probably the first place beginner go,
    they could understand stack and heap, length and capacity with this. Not
    sure if adding this means we should add to other places too.
    
    Superseeds rust-lang#76066
    pickfire committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    9e42d14 View commit details
    Browse the repository at this point in the history
  2. Add more details explaning the Vec visualization

    Suggested by oli-obk
    pickfire committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    9f338e1 View commit details
    Browse the repository at this point in the history
  3. Document security implications of std::env::temp_dir

    Update the sample code to not create an insecure temporary file.
    joshtriplett committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    27f3764 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Remove link to current section

    Co-authored-by: Mara Bos <[email protected]>
    pickfire and m-ou-se authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    9844d9e View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#79655 - pickfire:visual-vec, r=m-ou-se

    Add Vec visualization to understand capacity
    
    Visualize vector while differentiating between stack and heap.
    
    Inspired by cheats.rs, as this is probably the first place beginner go,
    they could understand stack and heap, length and capacity with this. Not
    sure if adding this means we should add to other places too.
    
    Superseeds rust-lang#76066
    
    r? `@m-ou-se`
    
    cc `@the8472` I put back the order of the fields as it feels weird, the note already explains that the order of fields is not guaranteed
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    a18813f View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#80172 - camelid:prelude-docs-consistent-pun…

    …ct, r=steveklabnik
    
    Use consistent punctuation for 'Prelude contents' docs
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    9abd746 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#80429 - JulianKnodt:ob_forest, r=Mark-Simul…

    …acrum
    
    Add regression test for mutual recursion in obligation forest
    
    Add regression test for rust-lang#75860 with a slightly smaller example.
    I was looking at what caused the issue and was surprised when it errors out on nightly, so I just added a regression test which should effectively close the issue, altho it would be nice to find the fix for reference.
    
    Also I found that 80066 is not fixed by whatever fixed 75860.
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    bcaf7df View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#80601 - steffahn:improve_format_string_gram…

    …mar, r=m-ou-se
    
    Improve grammar in documentation of format strings
    
    The docs previously were
    * using some weird `<` and `>` around some nonterminals
      * _correct me if these **did** have any meaning_
    * using of a (not explicitly defined) `text` nonterminal that didn’t explicitly disallow productions containing `'{'` or `'}'`
    * incorrect in not allowing for `x?` and `X?` productions of `type`
    * unnecessarily ambiguous, both
      * allowing `type` to be `''`, and
      * using an optional `[type]`
    * using inconsistent underscore/hyphenation style between `format_string` and `format_spec` vs `maybe-format`
    
    _Rendered:_
    ![Screenshot_20210101_230901](https://user-images.githubusercontent.com/3986214/103447038-69d7a180-4c86-11eb-8fa0-0a6160a7ff7a.png)
    _(current docs: https://doc.rust-lang.org/nightly/std/fmt/#syntax)_
    
    ```@rustbot``` modify labels: T-doc
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    8be36b1 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#81046 - rylev:unknown-external-crate, r=est…

    …ebank
    
    Improve unknown external crate error
    
    This improves error messages when unknown items in the crate root are encountered.
    
    Fixes rust-lang#63799
    
    r? ```@estebank```
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    a77c1d8 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#81178 - tmiasko:no-landing-pads, r=oli-obk

    Visit only terminators when removing landing pads
    
    No functional changes intended
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    cd0c54a View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#81179 - CPerezz:fix_interal_doc_warns, r=jy…

    …n514
    
    Fix broken links with `--document-private-items` in the standard library
    
    As it was suggested in rust-lang#81037 `SpecFromIter` is not
    in the scope and therefore we get a warning when we try to
    do document private intems in `rust/library/alloc/`.
    
    This addresses rust-lang#81037 by adding the trait in the scope as ```@jyn514```
    suggested and also adding an `allow(unused_imports)` flag so that
    the compiler does not complain, Since the trait is not used
    per se in the code, it's just needed to have properly documented
    docs.
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    b76f0f9 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#81184 - jyn514:combine-after, r=CraftSpider

    Remove unnecessary `after_run` function
    
    It's called at the same time and in the same place as `after_krate`, so
    they can be combined.
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    0aeb2fc View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#81185 - osa1:fix_80742, r=oli-obk

    Fix ICE in mir when evaluating SizeOf on unsized type
    
    Not quite ready yet. This tries to fix rust-lang#80742 as discussed on [Zulip topic][1],
    by using `delay_span_bug`.
    
    I don't understand what `delay_span_bug` does. It seems like my error message
    is never used. With this patch, in this program:
    
    ```rust
    #![allow(incomplete_features)]
    #![feature(const_evaluatable_checked)]
    #![feature(const_generics)]
    
    use std::fmt::Debug;
    use std::marker::PhantomData;
    use std::mem::size_of;
    
    struct Inline<T>
    where
        [u8; size_of::<T>() + 1]: ,
    {
        _phantom: PhantomData<T>,
        buf: [u8; size_of::<T>() + 1],
    }
    
    impl<T> Inline<T>
    where
        [u8; size_of::<T>() + 1]: ,
    {
        pub fn new(val: T) -> Inline<T> {
            todo!()
        }
    }
    
    fn main() {
        let dst = Inline::<dyn Debug>::new(0); // line 27
    }
    ```
    
    these errors are printed, both for line 27 (annotated line above):
    
    - "no function or associated item named `new` found for struct `Inline<dyn
      Debug>` in the current scope"
    - "the size for values of type `dyn Debug` cannot be known at compilation time"
    
    Second error makes sense, but I'm not sure about the first one and why it's
    even printed.
    
    Finally, I'm not sure about the span passing in `const_eval`.
    
    [1]: https://rust-lang.zulipchat.com/#narrow/stream/269128-miri/topic/Help.20fixing.20.2380742
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    bc950c8 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#81187 - eltociear:patch-6, r=jonas-schievink

    Fix typo in counters.rs
    
    formating -> formatting
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    2ebc036 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#81219 - joshtriplett:temp_dir-docs, r=sfackler

    Document security implications of std::env::temp_dir
    
    Update the sample code to not create an insecure temporary file.
    JohnTitor authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    d6c7a79 View commit details
    Browse the repository at this point in the history