Improve unknown external crate error #81046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rylev
force-pushed
the
unknown-external-crate
branch
from
28d9ee4
to
d51df05
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
jyn514
reviewed
Jan 15, 2021
Comment on lines
+2462
to
+2466
| let parent = if parent == kw::PathRoot { | ||
| "crate root".to_owned() | ||
| } else { | ||
| format!("`{}`", parent) | ||
| }; |
There was a problem hiding this comment.
Rather than special casing this here, does it make sense to change in impl Display for Symbol instead? Then you don't have to worry about missing it somewhere (and everyone else using this benefits as well).
There was a problem hiding this comment.
This is certainly a possibility. I didn't do this because I was unsure of the ramifications of renaming the symbol's string representation (particularly around json serialization/deserialization). The change I made seems to be the central place for diagnostics around path resolution (i.e., there are not UI tests that still reference {{root}}).
jyn514
added
A-diagnostics
estebank
reviewed
Jan 15, 2021
| format!("could not find `{}` in `{}`", ident, path[i - 1].ident); | ||
| let parent = path[i - 1].ident.name; | ||
| let parent = if parent == kw::PathRoot { | ||
| "crate root".to_owned() |
There was a problem hiding this comment.
Should it be root crate instead?
There was a problem hiding this comment.
Hmmm, the path root is normally referred to as the crate root as you can see here. root crate makes it sound like this refers to a crate itself but it does not, it's the root of the namespace hierarchy.
estebank
reviewed
Jan 15, 2021
estebank
reviewed
Jan 15, 2021
rylev
force-pushed
the
unknown-external-crate
branch
from
d51df05
to
d829e40
Compare
|
@bors r+ rollup |
|
📌 Commit 38b7742 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 20, 2021
…ebank Improve unknown external crate error This improves error messages when unknown items in the crate root are encountered. Fixes rust-lang#63799 r? `@estebank`
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 20, 2021
…ebank Improve unknown external crate error This improves error messages when unknown items in the crate root are encountered. Fixes rust-lang#63799 r? ``@estebank``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 21, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#79655 (Add Vec visualization to understand capacity) - rust-lang#80172 (Use consistent punctuation for 'Prelude contents' docs) - rust-lang#80429 (Add regression test for mutual recursion in obligation forest) - rust-lang#80601 (Improve grammar in documentation of format strings) - rust-lang#81046 (Improve unknown external crate error) - rust-lang#81178 (Visit only terminators when removing landing pads) - rust-lang#81179 (Fix broken links with `--document-private-items` in the standard library) - rust-lang#81184 (Remove unnecessary `after_run` function) - rust-lang#81185 (Fix ICE in mir when evaluating SizeOf on unsized type) - rust-lang#81187 (Fix typo in counters.rs) - rust-lang#81219 (Document security implications of std::env::temp_dir) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves error messages when unknown items in the crate root are encountered.
Fixes #63799
r? @estebank