resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint #80763

petrochenkov · 2021-01-06T20:48:22Z

This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (#42894 (comment)).

Unfortunately, the construction pub use foo as bar where foo is extern crate foo; was used by an older version bitflags, so turning it into an error causes too many regressions.
So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.

rust-highfive · 2021-01-06T20:48:26Z

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

estebank

r=me after new crater run to gauge current impact (which should be nil) and fixed tests:

---- [rustdoc] rustdoc/extern-links.rs stdout ----

error: rustdoc failed!
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/extern-links/auxiliary" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/extern-links" "/checkout/src/test/rustdoc/extern-links.rs"
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
error[E0365]: `extern_links` is private, and cannot be re-exported
  --> /checkout/src/test/rustdoc/extern-links.rs:10:9
   |
10 | pub use extern_links as extern_links2;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ re-export of private `extern_links`
   |
   = note: consider declaring type or module `extern_links` with `pub`

error[E0365]: `extern_links` is private, and cannot be re-exported
  --> /checkout/src/test/rustdoc/extern-links.rs:20:13
   |
20 |     pub use extern_links;
   |             ^^^^^^^^^^^^ re-export of private `extern_links`
   |
   = note: consider declaring type or module `extern_links` with `pub`

error: Compilation failed, aborting rustdoc

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0365`.

------------------------------------------


---- [rustdoc] rustdoc/issue-28927.rs stdout ----
For more information about this error, try `rustc --explain E0365`.

------------------------------------------



failures:
    [rustdoc] rustdoc/extern-links.rs
    [rustdoc] rustdoc/issue-28927.rs
    [rustdoc] rustdoc/src-links-external.rs

estebank · 2021-01-12T03:24:15Z

src/test/ui/pub/pub-reexport-priv-extern-crate.stderr

+note: the crate import `core` is defined here
+  --> $DIR/pub-reexport-priv-extern-crate.rs:5:5
+   |
+LL |     extern crate core;
+   |     ^^^^^^^^^^^^^^^^^^


Looking at these with fresh eyes, they could easily be structured suggestions, right?

Not sure what do you mean, this is a span_note.

(Anyway, changing diagnostics here would result in a large diff, and I don't want to make orthogonal changes to diagnostics in the same PR with changing the language, same applies to https://github.com/rust-lang/rust/pull/80763/files#r555486463)

estebank · 2021-01-12T03:24:53Z

src/test/ui/pub/pub-reexport-priv-extern-crate.stderr

-   = note: `#[deny(pub_use_of_private_extern_crate)]` on by default
-   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-   = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
+   = note: consider declaring type or module `core` with `pub`


Somewhat surprised we don't point at extern crate core; here.

estebank · 2021-01-12T03:28:01Z

Keep forgetting that the bots don't pay attention to the reviews...

@bors try @craterbot check

petrochenkov · 2021-01-12T07:26:18Z

@craterbot check

craterbot · 2021-01-12T07:26:29Z

👌 Experiment pr-80763 created and queued.
🤖 Automatically detected try build a23d1aca501a23a1d21cc03eeda899cc594a5613
⚠️ Try build based on commit 0406441, but latest commit is 94c6fe684d6ebdfc83b1c34f16d7f91db4e90e56. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-15T17:44:44Z

🚧 Experiment pr-80763 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2021-01-19T11:44:43Z

@craterbot retry-report

craterbot · 2021-01-19T11:44:44Z

🛠️ Generation of the report for pr-80763 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2021-01-19T21:23:18Z

Partial crater report - https://crater-reports.s3.amazonaws.com/pr-80763/index.html

petrochenkov · 2021-01-21T22:52:14Z

@jyn514
Any ideas on the CI failures (#80763 (comment))?
A deny-by-default lint wasn't reported for rustdoc tests for some reason.
How could this happen?
Are rustdoc tests special in some way? Do they allow lints? I can't find any such logic in compiletest.

jyn514 · 2021-01-21T23:07:26Z

A deny-by-default lint wasn't reported for rustdoc tests for some reason.

Rustdoc silences all lints by default:

rust/src/librustdoc/core.rs

Line 224 in 65767e5

    
           /// This function is used to setup the lint initialization. By default, in rustdoc, everything

. If you want to enable this lint in rustdoc, you can add it to lints_to_show.

petrochenkov · 2021-01-21T23:11:57Z

So the rustdoc tests are simply never compiled by an actual compiler, I see.
That's pretty logical.

petrochenkov · 2021-01-24T23:50:36Z

Errors from the crater results (there may be >1 errors in a single crate):

- `core` is private - 1707, `bitflags-0.8.2` and earlier
- `std` is private - 664, `bitflags-0.5.0` and earlier
- `libc_crate` is private - 10, `sdl2-0.14.0`
- `libc` is private - 7, `nix-0.4.3`
- `imgui` is private - 2, `imgui-sdl2-0.8.0`
- `event_loop_lib` is private - 1, `piston-0.10.1`
- `input_lib` is private - 1, `piston-0.10.1`
- `window_lib` is private - 1, `piston-0.10.1`
- `random` is private - 1, `probability-0.12.5`

Looks like we'll have to keep the lint, but I'll try to reduce the number of special cases it requires from the compiler.

petrochenkov · 2021-01-28T22:13:37Z

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-80763/retry-regressed-list.txt p=1

resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)). Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions. So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.

bors · 2021-03-04T05:07:42Z

⌛ Testing commit 7b021aa with merge 21accbf9a2e6f46bf98d196b1dc9f90a56ce4c96...

rust-log-analyzer · 2021-03-04T05:23:33Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Removing intermediate container 72d0c1e4756c
 ---> 18b2e3b309ae
Step 5/10 : RUN npm install es-check -g
 ---> Running in 223692fbd0f9
/node-v14.4.0-linux-x64/bin/es-check -> /node-v14.4.0-linux-x64/lib/node_modules/es-check/index.js

> [email protected] postinstall /node-v14.4.0-linux-x64/lib/node_modules/es-check/node_modules/spawn-sync
> node postinstall
+ [email protected]
added 95 packages from 44 contributors in 3.789s
Removing intermediate container 223692fbd0f9
 ---> b3b538b96e0b
---
Cloning into 'rust-toolstate'...
<Nothing changed>
+ es-check es5 ../src/librustdoc/html/static/main.js ../src/librustdoc/html/static/settings.js ../src/librustdoc/html/static/source-script.js ../src/librustdoc/html/static/storage.js

Cannot read property 'includes' of undefined

bors · 2021-03-04T05:25:59Z

💔 Test failed - checks-actions

JohnTitor · 2021-03-04T06:46:10Z

Unrelated CI failure, @bors retry

resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)). Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions. So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.

Rollup of 10 pull requests Successful merges: - rust-lang#80723 (Implement NOOP_METHOD_CALL lint) - rust-lang#80763 (resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint) - rust-lang#81136 (Improved IO Bytes Size Hint) - rust-lang#81939 (Add suggestion `.collect()` for iterators in iterators) - rust-lang#82289 (Fix underflow in specialized ZipImpl::size_hint) - rust-lang#82728 (Avoid unnecessary Vec construction in BufReader) - rust-lang#82764 (Add {BTreeMap,HashMap}::try_insert) - rust-lang#82770 (Add assert_matches macro.) - rust-lang#82773 (Add diagnostic item to `Default` trait) - rust-lang#82787 (Remove unused code from main.js) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Package changes: * bump bootstraps to 1.51.0. * adjust patches and cargo checksums as required * 1.51 failed to build natively on 32-bit armv7, there is hope that this is fixed with 1.52. (1.51 can be built with netbsd32 emulation on a aarch64 system). Upsteream changes: Version 1.52.0 (2021-05-06) ============================ Language -------- - [Added the `unsafe_op_in_unsafe_fn` lint, which checks whether the unsafe code in an `unsafe fn` is wrapped in a `unsafe` block.][79208] This lint is allowed by default, and may become a warning or hard error in a future edition. - [You can now cast mutable references to arrays to a pointer of the same type as the element.][81479] Compiler -------- - [Upgraded the default LLVM to LLVM 12.][81451] Added tier 3\* support for the following targets. - [`s390x-unknown-linux-musl`][82166] - [`riscv32gc-unknown-linux-musl` & `riscv64gc-unknown-linux-musl`][82202] - [`powerpc-unknown-openbsd`][82733] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [`OsString` now implements `Extend` and `FromIterator`.][82121] - [`cmp::Reverse` now has `#[repr(transparent)]` representation.][81879] - [`Arc<impl Error>` now implements `error::Error`.][80553] - [All integer division and remainder operations are now `const`.][80962] Stabilised APIs ------------- - [`Arguments::as_str`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`slice::partition_point`] - [`str::rsplit_once`] - [`str::split_once`] The following previously stable APIs are now `const`. - [`char::len_utf8`] - [`char::len_utf16`] - [`char::to_ascii_uppercase`] - [`char::to_ascii_lowercase`] - [`char::eq_ignore_ascii_case`] - [`u8::to_ascii_uppercase`] - [`u8::to_ascii_lowercase`] - [`u8::eq_ignore_ascii_case`] Rustdoc ------- - [Rustdoc lints are now treated as a tool lint, meaning that lints are now prefixed with `rustdoc::` (e.g. `#[warn(rustdoc::non_autolinks)]`).][80527] Using the old style is still allowed, and will become a warning in a future release. - [Rustdoc now supports argument files.][82261] - [Rustdoc now generates smart punctuation for documentation.][79423] - [You can now use "task lists" in Rustdoc Markdown.][81766] E.g. ```markdown - [x] Complete - [ ] Todo ``` Misc ---- - [You can now pass multiple filters to tests.][81356] E.g. `cargo test -- foo bar` will run all tests that match `foo` and `bar`. - [Rustup now distributes PDB symbols for the `std` library on Windows, allowing you to see `std` symbols when debugging.][82218] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Check the result cache before the DepGraph when ensuring queries][81855] - [Try fast_reject::simplify_type in coherence before doing full check][81744] - [Only store a LocalDefId in some HIR nodes][81611] - [Store HIR attributes in a side table][79519] Compatibility Notes ------------------- - [Cargo build scripts are now forbidden from setting `RUSTC_BOOTSTRAP`.] [cargo/9181] - [Removed support for the `x86_64-rumprun-netbsd` target.][82594] - [Deprecated the `x86_64-sun-solaris` target in favor of `x86_64-pc-solaris`.] [82216] - [Rustdoc now only accepts `,`, ` `, and `\t` as delimiters for specifying languages in code blocks.][78429] - [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] - [Changes in how proc macros handle whitespace may lead to panics when used with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] [84136]: rust-lang/rust#84136 [80763]: rust-lang/rust#80763 [82166]: rust-lang/rust#82166 [82121]: rust-lang/rust#82121 [81879]: rust-lang/rust#81879 [82261]: rust-lang/rust#82261 [82218]: rust-lang/rust#82218 [82216]: rust-lang/rust#82216 [82202]: rust-lang/rust#82202 [81855]: rust-lang/rust#81855 [81766]: rust-lang/rust#81766 [81744]: rust-lang/rust#81744 [81611]: rust-lang/rust#81611 [81479]: rust-lang/rust#81479 [81451]: rust-lang/rust#81451 [81356]: rust-lang/rust#81356 [80962]: rust-lang/rust#80962 [80553]: rust-lang/rust#80553 [80527]: rust-lang/rust#80527 [79519]: rust-lang/rust#79519 [79423]: rust-lang/rust#79423 [79208]: rust-lang/rust#79208 [78429]: rust-lang/rust#78429 [82733]: rust-lang/rust#82733 [82594]: rust-lang/rust#82594 [cargo/9181]: rust-lang/cargo#9181 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`Peekable::next_if`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if [`Peekable::next_if_eq`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_eq [`Arguments::as_str`]: https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str [`str::split_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once [`str::rsplit_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.rsplit_once [`slice::partition_point`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.partition_point [`char::len_utf8`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf8 [`char::len_utf16`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf16 [`char::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_uppercase [`char::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_lowercase [`char::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.eq_ignore_ascii_case [`u8::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_uppercase [`u8::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_lowercase [`u8::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.eq_ignore_ascii_case

Pkgsrc changes: * Bump bootstrap kit version to 1.51.0. * Adjust patches as needed. * Update checksum adjustments. * Fix syntax error in commands adjusting libserde_derive for Darwin Upstream changes: Version 1.52.1 (2021-05-10) ============================ This release disables incremental compilation, unless the user has explicitly opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable. This is due to the widespread, and frequently occuring, breakage encountered by Rust users due to newly enabled incremental verification in 1.52.0. Notably, Rust users **should** upgrade to 1.52.0 or 1.52.1: the bugs that are detected by newly added incremental verification are still present in past stable versions, and are not yet fixed on any channel. These bugs can lead to miscompilation of Rust binaries. These problems only affect incremental builds, so release builds with Cargo should not be affected unless the user has explicitly opted into incremental. Debug and check builds are affected. See [84970] for more details. [84970]: rust-lang/rust#84970 Version 1.52.0 (2021-05-06) ============================ Language -------- - [Added the `unsafe_op_in_unsafe_fn` lint, which checks whether the unsafe code in an `unsafe fn` is wrapped in a `unsafe` block.][79208] This lint is allowed by default, and may become a warning or hard error in a future edition. - [You can now cast mutable references to arrays to a pointer of the same type as the element.][81479] Compiler -------- - [Upgraded the default LLVM to LLVM 12.][81451] Added tier 3\* support for the following targets. - [`s390x-unknown-linux-musl`][82166] - [`riscv32gc-unknown-linux-musl` & `riscv64gc-unknown-linux-musl`][82202] - [`powerpc-unknown-openbsd`][82733] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [`OsString` now implements `Extend` and `FromIterator`.][82121] - [`cmp::Reverse` now has `#[repr(transparent)]` representation.][81879] - [`Arc<impl Error>` now implements `error::Error`.][80553] - [All integer division and remainder operations are now `const`.][80962] Stabilised APIs ------------- - [`Arguments::as_str`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`slice::partition_point`] - [`str::rsplit_once`] - [`str::split_once`] The following previously stable APIs are now `const`. - [`char::len_utf8`] - [`char::len_utf16`] - [`char::to_ascii_uppercase`] - [`char::to_ascii_lowercase`] - [`char::eq_ignore_ascii_case`] - [`u8::to_ascii_uppercase`] - [`u8::to_ascii_lowercase`] - [`u8::eq_ignore_ascii_case`] Rustdoc ------- - [Rustdoc lints are now treated as a tool lint, meaning that lints are now prefixed with `rustdoc::` (e.g. `#[warn(rustdoc::non_autolinks)]`).][80527] Using the old style is still allowed, and will become a warning in a future release. - [Rustdoc now supports argument files.][82261] - [Rustdoc now generates smart punctuation for documentation.][79423] - [You can now use "task lists" in Rustdoc Markdown.][81766] E.g. ```markdown - [x] Complete - [ ] Todo ``` Misc ---- - [You can now pass multiple filters to tests.][81356] E.g. `cargo test -- foo bar` will run all tests that match `foo` and `bar`. - [Rustup now distributes PDB symbols for the `std` library on Windows, allowing you to see `std` symbols when debugging.][82218] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Check the result cache before the DepGraph when ensuring queries][81855] - [Try fast_reject::simplify_type in coherence before doing full check][81744] - [Only store a LocalDefId in some HIR nodes][81611] - [Store HIR attributes in a side table][79519] Compatibility Notes ------------------- - [Cargo build scripts are now forbidden from setting `RUSTC_BOOTSTRAP`.][cargo/9181] - [Removed support for the `x86_64-rumprun-netbsd` target.][82594] - [Deprecated the `x86_64-sun-solaris` target in favor of `x86_64-pc-solaris`.][82216] - [Rustdoc now only accepts `,`, ` `, and `\t` as delimiters for specifying languages in code blocks.][78429] - [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] - [Changes in how proc macros handle whitespace may lead to panics when used with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] [84136]: rust-lang/rust#84136 [80763]: rust-lang/rust#80763 [82166]: rust-lang/rust#82166 [82121]: rust-lang/rust#82121 [81879]: rust-lang/rust#81879 [82261]: rust-lang/rust#82261 [82218]: rust-lang/rust#82218 [82216]: rust-lang/rust#82216 [82202]: rust-lang/rust#82202 [81855]: rust-lang/rust#81855 [81766]: rust-lang/rust#81766 [81744]: rust-lang/rust#81744 [81611]: rust-lang/rust#81611 [81479]: rust-lang/rust#81479 [81451]: rust-lang/rust#81451 [81356]: rust-lang/rust#81356 [80962]: rust-lang/rust#80962 [80553]: rust-lang/rust#80553 [80527]: rust-lang/rust#80527 [79519]: rust-lang/rust#79519 [79423]: rust-lang/rust#79423 [79208]: rust-lang/rust#79208 [78429]: rust-lang/rust#78429 [82733]: rust-lang/rust#82733 [82594]: rust-lang/rust#82594 [cargo/9181]: rust-lang/cargo#9181 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`Peekable::next_if`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if [`Peekable::next_if_eq`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_eq [`Arguments::as_str`]: https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str [`str::split_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once [`str::rsplit_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.rsplit_once [`slice::partition_point`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.partition_point [`char::len_utf8`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf8 [`char::len_utf16`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf16 [`char::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_uppercase [`char::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_lowercase [`char::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.eq_ignore_ascii_case [`u8::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_uppercase [`u8::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_lowercase [`u8::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.eq_ignore_ascii_case

rust-highfive assigned estebank Jan 6, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2021

This comment has been minimized.

Sign in to view

estebank approved these changes Jan 12, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2021

petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 19, 2021

petrochenkov removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 19, 2021

petrochenkov force-pushed the pubusecrate branch from 94c6fe6 to bbd7a93 Compare January 21, 2021 23:17

petrochenkov force-pushed the pubusecrate branch from bbd7a93 to d93b4be Compare January 28, 2021 22:04

petrochenkov changed the title ~~Turn deprecation lint pub_use_of_private_extern_crate into a hard error~~ resolve: Reduce scope of pub_use_of_private_extern_crate deprecation lint Jan 28, 2021

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021

Dylan-DPC-zz mentioned this pull request Mar 4, 2021

Rollup of 11 pull requests #82737

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2021

Dylan-DPC-zz mentioned this pull request Mar 5, 2021

Rollup of 9 pull requests #82785

Closed

JohnTitor mentioned this pull request Mar 5, 2021

Rollup of 10 pull requests #82790

Closed

This was referenced Mar 5, 2021

Rollup of 15 pull requests #82794

Closed

Rollup of 10 pull requests #82795

Merged

bors merged commit ec2619c into rust-lang:master Mar 5, 2021

rustbot added this to the 1.52.0 milestone Mar 5, 2021

jyn514 mentioned this pull request Apr 6, 2021

#[doc(hidden)] doesn't work on module or crate re-exports #83939

Closed

petrochenkov mentioned this pull request Apr 12, 2021

regression 1.52 - failed to resolve crate/module #84139

Closed

petrochenkov mentioned this pull request Jul 17, 2024

make pub_use_of_private_extern_crate show up in cargo's future breakage reports #127656

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint #80763

resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint #80763

petrochenkov commented Jan 6, 2021 •

edited

Loading

rust-highfive commented Jan 6, 2021

This comment has been minimized.

estebank left a comment •

edited

Loading

estebank Jan 12, 2021

petrochenkov Jan 21, 2021

estebank Jan 12, 2021

estebank commented Jan 12, 2021

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Jan 12, 2021

craterbot commented Jan 12, 2021

craterbot commented Jan 15, 2021

pietroalbini commented Jan 19, 2021

craterbot commented Jan 19, 2021

petrochenkov commented Jan 19, 2021

petrochenkov commented Jan 21, 2021

jyn514 commented Jan 21, 2021

petrochenkov commented Jan 21, 2021

petrochenkov commented Jan 24, 2021

petrochenkov commented Jan 28, 2021

This comment has been minimized.

This comment has been minimized.

bors commented Mar 4, 2021

rust-log-analyzer commented Mar 4, 2021

bors commented Mar 4, 2021

JohnTitor commented Mar 4, 2021

resolve: Reduce scope of pub_use_of_private_extern_crate deprecation lint #80763

resolve: Reduce scope of pub_use_of_private_extern_crate deprecation lint #80763

Conversation

petrochenkov commented Jan 6, 2021 • edited Loading

rust-highfive commented Jan 6, 2021

This comment has been minimized.

estebank left a comment • edited Loading

Choose a reason for hiding this comment

estebank Jan 12, 2021

Choose a reason for hiding this comment

petrochenkov Jan 21, 2021

Choose a reason for hiding this comment

estebank Jan 12, 2021

Choose a reason for hiding this comment

estebank commented Jan 12, 2021

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Jan 12, 2021

craterbot commented Jan 12, 2021

craterbot commented Jan 15, 2021

pietroalbini commented Jan 19, 2021

craterbot commented Jan 19, 2021

petrochenkov commented Jan 19, 2021

petrochenkov commented Jan 21, 2021

jyn514 commented Jan 21, 2021

petrochenkov commented Jan 21, 2021

petrochenkov commented Jan 24, 2021

petrochenkov commented Jan 28, 2021

This comment has been minimized.

This comment has been minimized.

bors commented Mar 4, 2021

rust-log-analyzer commented Mar 4, 2021

bors commented Mar 4, 2021

JohnTitor commented Mar 4, 2021

resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint #80763

resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint #80763

petrochenkov commented Jan 6, 2021 •

edited

Loading

estebank left a comment •

edited

Loading