Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression 1.52 - failed to resolve crate/module #84139

Closed
Mark-Simulacrum opened this issue Apr 12, 2021 · 6 comments
Closed

regression 1.52 - failed to resolve crate/module #84139

Mark-Simulacrum opened this issue Apr 12, 2021 · 6 comments
Labels
A-resolve Area: Name resolution regression-from-stable-to-stable Performance or correctness regression from one stable version to another. relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum Mark-Simulacrum added A-resolve Area: Name resolution T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Apr 12, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.52.0 milestone Apr 12, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 12, 2021
@petrochenkov
Copy link
Contributor

This is an expected result of #80763.
I sent PRs to affected crates, but not all of them were merged.

@Mark-Simulacrum
Copy link
Member Author

OK, sounds good. Tagging relnotes and removing prioritize; we'll mention this in release notes but no further work likely.

@Mark-Simulacrum Mark-Simulacrum added relnotes Marks issues that should be documented in the release notes of the next release. and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Apr 12, 2021
@jyn514
Copy link
Member

jyn514 commented Apr 12, 2021

The error message seems not great - shouldn't it error when you import bson, not when you use it?

@petrochenkov
Copy link
Contributor

petrochenkov commented Apr 12, 2021

IIRC, there are two bsons there - one in type namespace (this is the private crate item which we are no longer importing), and another public one in value or macro namespace - that's why the import itself doesn't fail.

@pietroalbini pietroalbini added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels May 4, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 4, 2021
@pietroalbini
Copy link
Member

This regression will unfortunately be included in 1.52.0 stable. Updating the labels.

@Mark-Simulacrum
Copy link
Member Author

Closing as "expected breakage"; I don't think we plan to take further action here.

@jyn514 jyn514 removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-resolve Area: Name resolution regression-from-stable-to-stable Performance or correctness regression from one stable version to another. relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants