Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #75715

Merged
merged 25 commits into from
Aug 19, 2020
Merged

Rollup of 7 pull requests #75715

merged 25 commits into from
Aug 19, 2020

Commits on Aug 16, 2020

  1. Adjust installation place for compiler docs

    This avoids conflicts when installing with rustup; rustup does not currently
    support overlapping installations.
    Mark-Simulacrum committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    172e67e View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Make OnceCell<T> transparent to dropck

    See the failed build in
    
    rust-lang#75555 (comment)
    
    for an example where we need this in real life
    matklad committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    695d86f View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. Configuration menu
    Copy the full SHA
    75d1373 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d49c0e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70dfe3f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ad01e9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7542615 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Remove #[cfg(miri)] from OnceCell tests

    They were carried over from once_cell crate, but they are not entirely
    correct (as miri now supports more things), and we don't run miri
    tests for std, so let's just remove them.
    
    Maybe one day we'll run miri in std, but then we can just re-install
    these attributes.
    matklad committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    34e7eac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    967ec1f View commit details
    Browse the repository at this point in the history
  3. Say tcx.lang_items() less

    jyn514 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8a0aa7b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3ddd8b2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    06d6d3d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9cf2fa8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    219e93d View commit details
    Browse the repository at this point in the history
  8. xpy fmt

    jyn514 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    121974e View commit details
    Browse the repository at this point in the history
  9. Add a test

    jyn514 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    570b0d9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dad8e11 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    aff01f8 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#75069 - lcnr:type-of-lazy-norm, r=varkor

    move const param structural match checks to wfcheck
    
    fixes rust-lang#75047 fixes rust-lang#74950
    
    We currently check for structural match violations inside of `type_of`.
    As we need to check the array length when checking if `[NonEq; arr_len]` is structural match, we potentially require the variance of an expression. Computing the variance requires `type_of` for all types though, resulting in a cycle error.
    
    r? @varkor @eddyb
    tmandry authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    672d009 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#75587 - RalfJung:mir-comment-fixes, r=ecsta…

    …tic-morse
    
    mir building: fix some comments
    
    r? @oli-obk
    
    At least I hope these fixes are right, please double-check.^^
    tmandry authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1f70776 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#75593 - Mark-Simulacrum:compiler-docs-must-…

    …not-overlap, r=pietroalbini
    
    Adjust installation place for compiler docs
    
    This avoids conflicts when installing with rustup; rustup does not currently
    support overlapping installations.
    
    r? @matthiaskrgr
    tmandry authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    0e7e939 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#75648 - matklad:lazy-dropck, r=KodrAus

    Make OnceCell<T> transparent to dropck
    
    See the failed build in
    
    rust-lang#75555 (comment)
    
    for an example where we need this in real life
    
    r? @ghost
    tmandry authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    4123237 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#75649 - jyn514:inherent-lang-impls, r=guill…

    …aumegomez
    
    Fix intra-doc links for inherent impls that are both lang items and not the default impl
    
    I found in rust-lang#75464 (comment) that `str::to_uppercase()` doesn't resolve while `str::trim()` does. The only real difference is that `to_uppercase` is defined in `alloc`, while trim is defined in `core`. It turns out that rustdoc was ignoring `lang_items.str_alloc_impl()` - it saw them in `collect_trait_impls`, but not for intra-doc links.
    
    This uses the same `impls` for all parts of rustdoc, so that there can be no more inconsistency. It does have the slight downside that the matches are no longer exhaustive but it will be very clear if a new lang item is missed because it will panic when you try to document it (and if you don't document it, does rustdoc really need to know about it?).
    
    ~~This needs a test case (probably just `str::to_uppercase`).~~ Added.
    
    This is best reviewed commit-by-commit.
    
    r? @GuillaumeGomez
    tmandry authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    7d14077 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#75674 - poliorcetics:intra-links-std-io, r=…

    …jyn514
    
    Move to intra doc links for std::io
    
    Helps with rust-lang#75080.
    
    @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
    
    r? @jyn514
    
    I had no problems with those files so I added some small links here and there.
    tmandry authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    0fdc8c0 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#75696 - matklad:mirit, r=RalfJung

    Remove `#[cfg(miri)]` from OnceCell tests
    
    They were carried over from once_cell crate, but they are not entirely
    correct (as miri now supports more things), and we don't run miri
    tests for std, so let's just remove them.
    
    Maybe one day we'll run miri in std, but then we can just re-install
    these attributes.
    tmandry authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    ad3db41 View commit details
    Browse the repository at this point in the history