-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 15 pull requests #75308
Merged
Merged
Rollup of 15 pull requests #75308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix commit 7dc3886 - previous commit doesn't adjust all targets
remove references to non existing code, expand solution suggestions remove unneeded code in solution
This basically adds the safety section of `*mut T::as_{ref,mut}` to the same methods on `NonNull` with minor modifications to fit the differences. Part of rust-lang#48929.
`ref` on an entire `let` pattern is discouraged, take a reference with `&` instead.
…ark-Simulacrum Update E0271 explanation When reading the explanation, I got confused by it. I hope the wording is clearer now.
…ulacrum adjust remaining targets - fix commit 7dc3886 - previous commit doesn't adjust all targets
Consistent variable name alloc for raw_vec
…, r=jyn514 Fix the documentation for move about Fn traits implementations Fixes rust-lang#74997. This uses the note from the [reference](https://doc.rust-lang.org/reference/types/closure.html#call-traits-and-coercions) but I can also just put a link to it or do both. @rusbot modify labels: C-bug T-doc T-libs
…alfJung Add `as_mut_ptr` to `NonNull<[T]>` Adds `as_mut_ptr` to shortcut converting a `NonNull<[T]>` to `*mut T` as proposed in rust-lang#74265 (comment). r? @RalfJung
Show multi extension example for Path in doctests
Add safety section to `NonNull::as_*` method docs This basically adds the safety section of `*mut T::as_{ref,mut}` to the same methods on `NonNull` with minor modifications to fit the differences. Part of rust-lang#48929.
Show relative example for Path ancestors
Separate example for Path strip_prefix
Show Path extension example change multi extension
Use assert! for Path exists example to check bool
Remove ambiguity from PathBuf pop example
…n, r=jonas-schievink fix `min_const_generics` version rust-lang#74877 (comment) > This should be 1.47.0
…kfire Clean up E0750 r? @Dylan-DPC
…eGomez Clean up E0502 `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead.
📌 Commit e6dfd30 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 8, 2020
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
as_mut_ptr
toNonNull<[T]>
#75248 (Addas_mut_ptr
toNonNull<[T]>
)NonNull::as_*
method docs #75266 (Add safety section toNonNull::as_*
method docs)min_const_generics
version #75290 (fixmin_const_generics
version)Failed merges:
r? @ghost