Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #75308

Merged
merged 32 commits into from
Aug 9, 2020
Merged

Rollup of 15 pull requests #75308

merged 32 commits into from
Aug 9, 2020

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

stlankes and others added 30 commits July 28, 2020 11:26
- fix commit 7dc3886
- previous commit doesn't adjust all targets
remove references to non existing code,
expand solution suggestions
remove unneeded code in solution
This basically adds the safety section of `*mut T::as_{ref,mut}` to the
same methods on `NonNull` with minor modifications to fit the
differences.

Part of rust-lang#48929.
`ref` on an entire `let` pattern is discouraged, take a reference with `&` instead.
…ark-Simulacrum

Update E0271 explanation

When reading the explanation, I got confused by it. I hope the wording is clearer now.
…ulacrum

adjust remaining targets

- fix commit 7dc3886
- previous commit doesn't adjust all targets
Consistent variable name alloc for raw_vec
…, r=jyn514

Fix the documentation for move about Fn traits implementations

Fixes rust-lang#74997.

This uses the note from the [reference](https://doc.rust-lang.org/reference/types/closure.html#call-traits-and-coercions) but I can also just put a link to it or do both.

@rusbot modify labels: C-bug T-doc T-libs
…alfJung

Add `as_mut_ptr` to `NonNull<[T]>`

Adds `as_mut_ptr` to shortcut converting a `NonNull<[T]>` to `*mut T` as proposed in rust-lang#74265 (comment).

r? @RalfJung
Show multi extension example for Path in doctests
Add safety section to `NonNull::as_*` method docs

This basically adds the safety section of `*mut T::as_{ref,mut}` to the
same methods on `NonNull` with minor modifications to fit the
differences.

Part of rust-lang#48929.
Show Path extension example change multi extension
Use assert! for Path exists example to check bool
…n, r=jonas-schievink

fix `min_const_generics` version

rust-lang#74877 (comment)

> This should be 1.47.0
…eGomez

Clean up E0502

`ref` on an entire `let` pattern is discouraged, take a reference with `&` instead.
@JohnTitor
Copy link
Member Author

@rustbot modify labels: +rollup
@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Aug 8, 2020

📌 Commit e6dfd30 has been approved by JohnTitor

@rustbot rustbot added the rollup A PR which is a rollup label Aug 8, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 8, 2020
@bors
Copy link
Contributor

bors commented Aug 8, 2020

⌛ Testing commit e6dfd30 with merge dcf1077...

@bors
Copy link
Contributor

bors commented Aug 9, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: JohnTitor
Pushing dcf1077 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2020
@bors bors merged commit dcf1077 into rust-lang:master Aug 9, 2020
@JohnTitor JohnTitor deleted the rollup-vnnny43 branch August 9, 2020 01:10
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.