Add safety section to NonNull::as_* method docs
#75266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @KodrAus (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @RalfJung |
RalfJung
reviewed
Aug 8, 2020
RalfJung
reviewed
Aug 8, 2020
RalfJung
reviewed
Aug 8, 2020
This basically adds the safety section of `*mut T::as_{ref,mut}` to the
same methods on `NonNull` with minor modifications to fit the
differences.
Part of #48929.
|
Looking good, thanks! |
|
📌 Commit c2099b5 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 8, 2020
Rollup of 15 pull requests Successful merges: - rust-lang#74712 (Update E0271 explanation) - rust-lang#74842 (adjust remaining targets) - rust-lang#75151 (Consistent variable name alloc for raw_vec) - rust-lang#75162 (Fix the documentation for move about Fn traits implementations) - rust-lang#75248 (Add `as_mut_ptr` to `NonNull<[T]>`) - rust-lang#75262 (Show multi extension example for Path in doctests) - rust-lang#75266 (Add safety section to `NonNull::as_*` method docs) - rust-lang#75284 (Show relative example for Path ancestors) - rust-lang#75285 (Separate example for Path strip_prefix) - rust-lang#75287 (Show Path extension example change multi extension) - rust-lang#75288 (Use assert! for Path exists example to check bool) - rust-lang#75289 (Remove ambiguity from PathBuf pop example) - rust-lang#75290 (fix `min_const_generics` version) - rust-lang#75291 (Clean up E0750) - rust-lang#75292 (Clean up E0502) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically adds the safety section of
*mut T::as_{ref,mut}to thesame methods on
NonNullwith minor modifications to fit thedifferences.
Part of #48929.