Remove special case for `simd_shuffle` arg promotion #69280

ecstatic-morse · 2020-02-19T05:34:18Z

After rust-lang/stdarch#825, these intrinsics are now defined with #[rustc_args_required_const(2)], so the special-case is no longer necessary.

After rust-lang/stdarch#825, these intrinsics are now defined with `#[rustc_args_required_const(2)]`, so the special-case is no longer necessary.

rust-highfive · 2020-02-19T05:34:22Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2020-02-19T05:52:28Z

@bors r+

bors · 2020-02-19T05:52:29Z

📌 Commit f581b55 has been approved by petrochenkov

petrochenkov · 2020-02-19T05:54:10Z

FWIW, we have function parameter attributes now, so #[rustc_args_required_const(N)] on functions could become #[rustc_required_const] on function parameters.
Perhaps we need to open an issue for this.

ecstatic-morse · 2020-02-19T05:59:16Z

FWIW, we have function parameter attributes now, so #[rustc_args_required_const(N)] on functions could become #[rustc_required_const] on function parameters.
Perhaps we need to open an issue for this.

Ooh, this would be much better. I can open the issue if you like?

petrochenkov · 2020-02-19T06:26:48Z

I can open the issue if you like?

Yeah, that would be nice.

rust-highfive · 2020-02-19T06:38:43Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-19T05:34:53.4400327Z ========================== Starting Command Output ===========================
2020-02-19T05:34:53.4401858Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/a7891c47-61b2-4dcd-9278-1721be26313d.sh
2020-02-19T05:34:53.4401891Z 
2020-02-19T05:34:53.4404614Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-19T05:34:53.4410631Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69280/merge to s
2020-02-19T05:34:53.4412106Z Task         : Get sources
2020-02-19T05:34:53.4412140Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-19T05:34:53.4412218Z Version      : 1.0.0
2020-02-19T05:34:53.4412251Z Author       : Microsoft
---
2020-02-19T05:34:54.4436592Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-19T05:34:54.4447859Z ##[command]git config gc.auto 0
2020-02-19T05:34:54.4451705Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-19T05:34:54.4454801Z ##[command]git config --get-all http.proxy
2020-02-19T05:34:54.4464371Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69280/merge:refs/remotes/pull/69280/merge
---
2020-02-19T06:28:37.0476163Z .................................................................................................... 1700/9675
2020-02-19T06:28:41.3858396Z .................................................................................................... 1800/9675
2020-02-19T06:28:51.9646493Z ...................................i................................................................ 1900/9675
2020-02-19T06:28:58.8323586Z .................................................................................................... 2000/9675
2020-02-19T06:29:11.4241421Z .........................iiiii...................................................................... 2100/9675
2020-02-19T06:29:20.0926706Z .................................................................................................... 2300/9675
2020-02-19T06:29:22.2309214Z .................................................................................................... 2400/9675
2020-02-19T06:29:26.3173044Z .................................................................................................... 2500/9675
2020-02-19T06:29:44.9547546Z .................................................................................................... 2600/9675
---
2020-02-19T06:32:10.5857282Z i................................................................................................... 5000/9675
2020-02-19T06:32:18.4538715Z .................................................................................................... 5100/9675
2020-02-19T06:32:22.6567192Z ...........................i........................................................................ 5200/9675
2020-02-19T06:32:31.8245362Z .................................................................................................... 5300/9675
2020-02-19T06:32:36.5966098Z ...iiii........i...i................................................................................ 5400/9675
2020-02-19T06:32:45.1174632Z .................................................................................................... 5600/9675
2020-02-19T06:32:54.4409875Z ............................................................................................i....... 5700/9675
2020-02-19T06:33:01.7405067Z .................................................................................................... 5800/9675
2020-02-19T06:33:06.3247106Z ..........................................................................................i......... 5900/9675
2020-02-19T06:33:06.3247106Z ..........................................................................................i......... 5900/9675
2020-02-19T06:33:14.9661290Z ...................................................................................ii...i..ii....... 6000/9675
2020-02-19T06:33:35.3168323Z .................................................................................................... 6200/9675
2020-02-19T06:33:41.0094020Z .................................................................................................... 6300/9675
2020-02-19T06:33:44.5052913Z .................................................................................................... 6400/9675
2020-02-19T06:33:44.5052913Z .................................................................................................... 6400/9675
2020-02-19T06:33:56.1661766Z ...........i..ii.................................................................................... 6500/9675
2020-02-19T06:34:14.0700167Z .................................................................................................... 6700/9675
2020-02-19T06:34:16.0380476Z ...i................................................................................................ 6800/9675
2020-02-19T06:34:18.1132169Z .................................................................................................... 6900/9675
2020-02-19T06:34:20.2385444Z .........................i.......................................................................... 7000/9675
---
2020-02-19T06:35:50.4224243Z .................................................................................................... 7700/9675
2020-02-19T06:35:55.1287745Z .................................................................................................... 7800/9675
2020-02-19T06:36:00.9669631Z .................................................................................................... 7900/9675
2020-02-19T06:36:10.4292628Z .................................................................................................... 8000/9675
2020-02-19T06:36:15.8378245Z ...........iiiiiii.i................................................................................ 8100/9675
2020-02-19T06:36:24.6494603Z ..........................................F.F.F....i.....Fi......................................... 8200/9675
2020-02-19T06:36:37.1213173Z .................................................................................................... 8400/9675
2020-02-19T06:36:48.8857860Z .................................................................................................... 8500/9675
2020-02-19T06:36:55.0621750Z .................................................................................................... 8600/9675
2020-02-19T06:37:03.4391531Z .................................................................................................... 8700/9675
---
2020-02-19T06:38:37.2690579Z ---- [ui] ui/issues/issue-38074.rs stdout ----
2020-02-19T06:38:37.2690808Z 
2020-02-19T06:38:37.2691212Z error: test compilation failed although it shouldn't!
2020-02-19T06:38:37.2691420Z status: exit code: 101
2020-02-19T06:38:37.2692615Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-38074.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-38074/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-38074/auxiliary"
2020-02-19T06:38:37.2693269Z ------------------------------------------
2020-02-19T06:38:37.2693449Z 
2020-02-19T06:38:37.2693835Z ------------------------------------------
2020-02-19T06:38:37.2694029Z stderr:
2020-02-19T06:38:37.2694029Z stderr:
2020-02-19T06:38:37.2694384Z ------------------------------------------
2020-02-19T06:38:37.2694609Z error: internal compiler error: src/librustc_codegen_ssa/mir/block.rs:622: shuffle indices must be constant
2020-02-19T06:38:37.2695224Z    |
2020-02-19T06:38:37.2695224Z    |
2020-02-19T06:38:37.2695624Z LL |     let r: u64x2 = unsafe { simd_shuffle2(a, a, [0-0, 0-0]) };
2020-02-19T06:38:37.2696015Z 
2020-02-19T06:38:37.2696404Z thread 'rustc' panicked at 'Box<Any>', <::std::macros::panic macros>:2:4
2020-02-19T06:38:37.2696609Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-19T06:38:37.2696785Z 
2020-02-19T06:38:37.2696785Z 
2020-02-19T06:38:37.2696964Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-19T06:38:37.2697120Z 
2020-02-19T06:38:37.2697683Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-02-19T06:38:37.2697869Z 
2020-02-19T06:38:37.2698278Z note: rustc 1.43.0-nightly (616e4f6ff 2020-02-19) running on x86_64-unknown-linux-gnu
2020-02-19T06:38:37.2698489Z 
2020-02-19T06:38:37.2698955Z note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
2020-02-19T06:38:37.2699351Z error: aborting due to previous error
2020-02-19T06:38:37.2699507Z 
2020-02-19T06:38:37.2699660Z 
2020-02-19T06:38:37.2700017Z ------------------------------------------
2020-02-19T06:38:37.2700017Z ------------------------------------------
2020-02-19T06:38:37.2700537Z 
2020-02-19T06:38:37.2701104Z 
2020-02-19T06:38:37.2701582Z ---- [ui] ui/simd-intrinsic/simd-intrinsic-generic-elements.rs stdout ----
2020-02-19T06:38:37.2702415Z 
2020-02-19T06:38:37.2702588Z error: Error: expected failure status (Some(1)) but received status Some(101).
2020-02-19T06:38:37.2702739Z status: exit code: 101
2020-02-19T06:38:37.2703724Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/simd-intrinsic/simd-intrinsic-generic-elements.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-generic-elements" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-generic-elements/auxiliary"
2020-02-19T06:38:37.2704260Z ------------------------------------------
2020-02-19T06:38:37.2704401Z 
2020-02-19T06:38:37.2704703Z ------------------------------------------
2020-02-19T06:38:37.2704838Z stderr:
2020-02-19T06:38:37.2704838Z stderr:
2020-02-19T06:38:37.2705154Z ------------------------------------------
2020-02-19T06:38:37.2705541Z error[E0511]: invalid monomorphization of `simd_insert` intrinsic: expected SIMD input type, found non-SIMD `i32`
2020-02-19T06:38:37.2706183Z    |
2020-02-19T06:38:37.2706183Z    |
2020-02-19T06:38:37.2706307Z LL |         simd_insert(0, 0, 0);
2020-02-19T06:38:37.2706555Z 
2020-02-19T06:38:37.2706555Z 
2020-02-19T06:38:37.2706747Z error[E0511]: invalid monomorphization of `simd_insert` intrinsic: expected inserted type `i32` (element of input `i32x4`), found `f64`
2020-02-19T06:38:37.2707273Z    |
2020-02-19T06:38:37.2707273Z    |
2020-02-19T06:38:37.2707395Z LL |         simd_insert(x, 0, 1.0);
2020-02-19T06:38:37.2707642Z 
2020-02-19T06:38:37.2707642Z 
2020-02-19T06:38:37.2707776Z error[E0511]: invalid monomorphization of `simd_extract` intrinsic: expected return type `i32` (element of input `i32x4`), found `f32`
2020-02-19T06:38:37.2708276Z    |
2020-02-19T06:38:37.2708276Z    |
2020-02-19T06:38:37.2708413Z LL |         simd_extract::<_, f32>(x, 0);
2020-02-19T06:38:37.2708657Z 
2020-02-19T06:38:37.2708657Z 
2020-02-19T06:38:37.2708895Z error: internal compiler error: src/librustc_codegen_ssa/mir/block.rs:622: shuffle indices must be constant
2020-02-19T06:38:37.2709332Z    |
2020-02-19T06:38:37.2709332Z    |
2020-02-19T06:38:37.2709457Z LL |         simd_shuffle2::<i32, i32>(0, 0, [0; 2]);
2020-02-19T06:38:37.2709663Z 
2020-02-19T06:38:37.2709959Z thread 'rustc' panicked at 'Box<Any>', <::std::macros::panic macros>:2:4
2020-02-19T06:38:37.2710279Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-19T06:38:37.2711707Z 
2020-02-19T06:38:37.2711707Z 
2020-02-19T06:38:37.2711887Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-19T06:38:37.2712107Z 
2020-02-19T06:38:37.2712656Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-02-19T06:38:37.2713217Z 
2020-02-19T06:38:37.2713534Z note: rustc 1.43.0-nightly (616e4f6ff 2020-02-19) running on x86_64-unknown-linux-gnu
2020-02-19T06:38:37.2713642Z 
2020-02-19T06:38:37.2713957Z note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
2020-02-19T06:38:37.2714149Z error: aborting due to 4 previous errors
2020-02-19T06:38:37.2714228Z 
2020-02-19T06:38:37.2714667Z For more information about this error, try `rustc --explain E0511`.
2020-02-19T06:38:37.2714774Z 
2020-02-19T06:38:37.2714774Z 
2020-02-19T06:38:37.2715036Z ------------------------------------------
2020-02-19T06:38:37.2715155Z 
2020-02-19T06:38:37.2715246Z 
2020-02-19T06:38:37.2715538Z ---- [ui] ui/simd-intrinsic/simd-intrinsic-inlining-issue67557-ice.rs stdout ----
2020-02-19T06:38:37.2715643Z 
2020-02-19T06:38:37.2715931Z error: test compilation failed although it shouldn't!
2020-02-19T06:38:37.2716051Z status: exit code: 101
2020-02-19T06:38:37.2716869Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/simd-intrinsic/simd-intrinsic-inlining-issue67557-ice.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-inlining-issue67557-ice/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Zmir-opt-level=3" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-inlining-issue67557-ice/auxiliary"
2020-02-19T06:38:37.2717311Z ------------------------------------------
2020-02-19T06:38:37.2717418Z 
2020-02-19T06:38:37.2717677Z ------------------------------------------
2020-02-19T06:38:37.2717808Z stderr:
2020-02-19T06:38:37.2717808Z stderr:
2020-02-19T06:38:37.2718064Z ------------------------------------------
2020-02-19T06:38:37.2718326Z error: internal compiler error: src/librustc_codegen_ssa/mir/block.rs:622: shuffle indices must be constant
2020-02-19T06:38:37.2718831Z    |
2020-02-19T06:38:37.2718831Z    |
2020-02-19T06:38:37.2718959Z LL |     simd_shuffle2(Simd2(10, 11), Simd2(12, 13), [0, 3])
2020-02-19T06:38:37.2719166Z 
2020-02-19T06:38:37.2719473Z thread 'rustc' panicked at 'Box<Any>', <::std::macros::panic macros>:2:4
2020-02-19T06:38:37.2719604Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-19T06:38:37.2719699Z 
2020-02-19T06:38:37.2719699Z 
2020-02-19T06:38:37.2719824Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-19T06:38:37.2719917Z 
2020-02-19T06:38:37.2720266Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-02-19T06:38:37.2720393Z 
2020-02-19T06:38:37.2720704Z note: rustc 1.43.0-nightly (616e4f6ff 2020-02-19) running on x86_64-unknown-linux-gnu
2020-02-19T06:38:37.2720811Z 
2020-02-19T06:38:37.2721207Z note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z unstable-options -Z mir-opt-level=3 -C prefer-dynamic -C rpath -C debuginfo=0
2020-02-19T06:38:37.2721429Z error: aborting due to previous error
2020-02-19T06:38:37.2721536Z 
2020-02-19T06:38:37.2721623Z 
2020-02-19T06:38:37.2721880Z ------------------------------------------
2020-02-19T06:38:37.2721880Z ------------------------------------------
2020-02-19T06:38:37.2721997Z 
2020-02-19T06:38:37.2722085Z 
2020-02-19T06:38:37.2722368Z ---- [ui] ui/simd-intrinsic/simd-intrinsic-inlining-issue67557.rs stdout ----
2020-02-19T06:38:37.2722476Z 
2020-02-19T06:38:37.2722756Z error: test compilation failed although it shouldn't!
2020-02-19T06:38:37.2722875Z status: exit code: 101
2020-02-19T06:38:37.2723809Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/simd-intrinsic/simd-intrinsic-inlining-issue67557.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-inlining-issue67557/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Zmir-opt-level=3" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-inlining-issue67557/auxiliary"
2020-02-19T06:38:37.2725784Z ------------------------------------------
2020-02-19T06:38:37.2725994Z 
2020-02-19T06:38:37.2726287Z ------------------------------------------
2020-02-19T06:38:37.2726425Z stderr:
2020-02-19T06:38:37.2726425Z stderr:
2020-02-19T06:38:37.2726685Z ------------------------------------------
2020-02-19T06:38:37.2727665Z error: internal compiler error: src/librustc_codegen_ssa/mir/block.rs:622: shuffle indices must be constant
2020-02-19T06:38:37.2734135Z    |
2020-02-19T06:38:37.2734135Z    |
2020-02-19T06:38:37.2734436Z LL |         let p_res: Simd2 = simd_shuffle2(Simd2(10, 11), Simd2(12, 13), [0, 1]);
2020-02-19T06:38:37.2734705Z 
2020-02-19T06:38:37.2735286Z thread 'rustc' panicked at 'Box<Any>', <::std::macros::panic macros>:2:4
2020-02-19T06:38:37.2735444Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-19T06:38:37.2735589Z 
2020-02-19T06:38:37.2735589Z 
2020-02-19T06:38:37.2735977Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-19T06:38:37.2736114Z 
2020-02-19T06:38:37.2736627Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-02-19T06:38:37.2736768Z 
2020-02-19T06:38:37.2737154Z note: rustc 1.43.0-nightly (616e4f6ff 2020-02-19) running on x86_64-unknown-linux-gnu
2020-02-19T06:38:37.2737451Z 
2020-02-19T06:38:37.2737981Z note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z unstable-options -Z mir-opt-level=3 -C prefer-dynamic -C rpath -C debuginfo=0
2020-02-19T06:38:37.2738306Z error: aborting due to previous error
2020-02-19T06:38:37.2738420Z 
2020-02-19T06:38:37.2738529Z 
2020-02-19T06:38:37.2738880Z ------------------------------------------
2020-02-19T06:38:37.2738880Z ------------------------------------------
2020-02-19T06:38:37.2739011Z 
2020-02-19T06:38:37.2739121Z 
2020-02-19T06:38:37.2739482Z ---- [ui] ui/simd/simd-intrinsic-generic-elements.rs stdout ----
2020-02-19T06:38:37.2739614Z 
2020-02-19T06:38:37.2739947Z error: test compilation failed although it shouldn't!
2020-02-19T06:38:37.2740099Z status: exit code: 101
2020-02-19T06:38:37.2741027Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/simd/simd-intrinsic-generic-elements.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd/simd-intrinsic-generic-elements/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd/simd-intrinsic-generic-elements/auxiliary"
2020-02-19T06:38:37.2741584Z ------------------------------------------
2020-02-19T06:38:37.2741713Z 
2020-02-19T06:38:37.2742028Z ------------------------------------------
2020-02-19T06:38:37.2742192Z stderr:
2020-02-19T06:38:37.2742192Z stderr:
2020-02-19T06:38:37.2742514Z ------------------------------------------
2020-02-19T06:38:37.2742693Z error: internal compiler error: src/librustc_codegen_ssa/mir/block.rs:622: shuffle indices must be constant
2020-02-19T06:38:37.2743228Z    |
2020-02-19T06:38:37.2743228Z    |
2020-02-19T06:38:37.2743368Z LL |         all_eq!(simd_shuffle2(x2, y2, [3, 0]), i32x2(121, 20));
2020-02-19T06:38:37.2743637Z 
2020-02-19T06:38:37.2744015Z thread 'rustc' panicked at 'Box<Any>', <::std::macros::panic macros>:2:4
2020-02-19T06:38:37.2744193Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-19T06:38:37.2744307Z 
2020-02-19T06:38:37.2744307Z 
2020-02-19T06:38:37.2744440Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-19T06:38:37.2744571Z 
2020-02-19T06:38:37.2744994Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-02-19T06:38:37.2745128Z 
2020-02-19T06:38:37.2745507Z note: rustc 1.43.0-nightly (616e4f6ff 2020-02-19) running on x86_64-unknown-linux-gnu
2020-02-19T06:38:37.2745657Z 
2020-02-19T06:38:37.2746092Z note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
2020-02-19T06:38:37.2746374Z error: aborting due to previous error
2020-02-19T06:38:37.2746489Z 
2020-02-19T06:38:37.2746598Z 
2020-02-19T06:38:37.2746946Z ------------------------------------------
---
2020-02-19T06:38:37.2754261Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-19T06:38:37.2754637Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-19T06:38:37.2754810Z 
2020-02-19T06:38:37.2755062Z 
2020-02-19T06:38:37.2756874Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-19T06:38:37.2757582Z 
2020-02-19T06:38:37.2757749Z 
2020-02-19T06:38:37.2757938Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-19T06:38:37.2758148Z Build completed unsuccessfully in 0:56:48
2020-02-19T06:38:37.2758148Z Build completed unsuccessfully in 0:56:48
2020-02-19T06:38:37.2800541Z == clock drift check ==
2020-02-19T06:38:37.2818496Z   local time: Wed Feb 19 06:38:37 UTC 2020
2020-02-19T06:38:37.8156638Z   network time: Wed, 19 Feb 2020 06:38:37 GMT
2020-02-19T06:38:37.8156820Z == end clock drift check ==
2020-02-19T06:38:38.2732077Z 
2020-02-19T06:38:38.2825662Z ##[error]Bash exited with code '1'.
2020-02-19T06:38:38.2863374Z ##[section]Finishing: Run build
2020-02-19T06:38:38.2886751Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69280/merge to s
2020-02-19T06:38:38.2888609Z Task         : Get sources
2020-02-19T06:38:38.2888678Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-19T06:38:38.2888728Z Version      : 1.0.0
2020-02-19T06:38:38.2888773Z Author       : Microsoft
2020-02-19T06:38:38.2888773Z Author       : Microsoft
2020-02-19T06:38:38.2889308Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-19T06:38:38.2889364Z ==============================================================================
2020-02-19T06:38:38.6924068Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-19T06:38:38.6977216Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69280/merge to s
2020-02-19T06:38:38.7080557Z Cleaning up task key
2020-02-19T06:38:38.7081329Z Start cleaning up orphan processes.
2020-02-19T06:38:38.7176465Z Terminate orphan process: pid (7031) (python)
2020-02-19T06:38:38.7465070Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

ecstatic-morse · 2020-02-19T07:36:30Z

@bors r-

ecstatic-morse · 2020-02-19T07:38:21Z

Some tests declare their own simd_shuffle platform intrinsic, which now needs the attribute. I assume this is okay (cc @petrochenkov).

@bors r=petrochenkov

bors · 2020-02-19T07:38:22Z

📌 Commit b43dc80 has been approved by petrochenkov

…pecial-case, r=petrochenkov Remove special case for `simd_shuffle` arg promotion After rust-lang/stdarch#825, these intrinsics are now defined with `#[rustc_args_required_const(2)]`, so the special-case is no longer necessary.

@ghost

Rollup of 5 pull requests Successful merges: - #68863 (ci: switch macOS builders to 10.15) - #69142 (Add shared script for linkchecking books.) - #69248 (Don't eliminate frame pointers on thumb targets) - #69280 (Remove special case for `simd_shuffle` arg promotion) - #69284 (Reword OpenOptions::{create, create_new} doc.) Failed merges: r? @ghost

This change was made in `stdarch` but not `packed_simd`. See rust-lang/rust#69280 for background.

…fle-no-special-case, r=petrochenkov" This reverts commit 61d3b6d, reversing changes made to c6ad1e2.

@petrochenkov

…nkov Revert #69280 Resolves #69313 by reverting #69280. After #69280, `#[rustc_args_required_const(2)]` is required on the declaration of `simd_shuffle` intrinsics. This is allowed breakage, since you can't define platform intrinsics on stable. However, the latest release of the widely used `packed_simd` crate defines these intrinsics without the requisite attribute. Since there's no urgency to merge #69280, let's revert it. We can reconsider when rust-lang/packed_simd#278 is included in a point release of `packed_simd`. r? @petrochenkov

This change was made in `stdarch` but not `packed_simd`. See rust-lang/rust#69280 for background.

ecstatic-morse added 2 commits February 18, 2020 21:29

Remove special case for simd_shuffle arg promotion

d194676

After rust-lang/stdarch#825, these intrinsics are now defined with `#[rustc_args_required_const(2)]`, so the special-case is no longer necessary.

Remove mention of simd_shuffle promotion from comments

f581b55

rust-highfive assigned petrochenkov Feb 19, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 19, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2020

ecstatic-morse mentioned this pull request Feb 19, 2020

Replace #[rustc_args_required_const(n)] with per-argument attr #69282

Closed

Add #[rustc_args_required_const] to simd_shuffle tests

b43dc80

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 19, 2020

ecstatic-morse force-pushed the promote-shuffle-no-special-case branch from 063186f to b43dc80 Compare February 19, 2020 07:36

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2020

This was referenced Feb 19, 2020

Rollup of 5 pull requests #69292

Closed

Rollup of 5 pull requests #69293

Merged

bors merged commit 61d3b6d into rust-lang:master Feb 19, 2020

ecstatic-morse mentioned this pull request Feb 20, 2020

ICE with rustc claiming non-constant shuffle indices when they are constant (block.rs:622) #69313

Closed

ecstatic-morse added a commit to ecstatic-morse/packed_simd that referenced this pull request Feb 20, 2020

Mark simd_shuffle intrinsics as rustc_args_required_const

f760867

This change was made in `stdarch` but not `packed_simd`. See rust-lang/rust#69280 for background.

ecstatic-morse mentioned this pull request Feb 20, 2020

Mark simd_shuffle intrinsics as rustc_args_required_const rust-lang/packed_simd#278

Merged

ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Feb 21, 2020

Revert "Rollup merge of rust-lang#69280 - ecstatic-morse:promote-shuf…

16790ae

…fle-no-special-case, r=petrochenkov" This reverts commit 61d3b6d, reversing changes made to c6ad1e2.

ecstatic-morse mentioned this pull request Feb 21, 2020

Revert #69280 #69333

Merged

ecstatic-morse mentioned this pull request Feb 26, 2020

Remove special-case for simd_shuffle intrinsics in promotion #69493

Closed

hsivonen pushed a commit to hsivonen/packed_simd that referenced this pull request Sep 10, 2020

Mark simd_shuffle intrinsics as rustc_args_required_const

736c677

This change was made in `stdarch` but not `packed_simd`. See rust-lang/rust#69280 for background.

workingjubilee pushed a commit to rust-lang/packed_simd that referenced this pull request Sep 25, 2020

Mark simd_shuffle intrinsics as rustc_args_required_const

a8273dd

This change was made in `stdarch` but not `packed_simd`. See rust-lang/rust#69280 for background.

ecstatic-morse deleted the promote-shuffle-no-special-case branch October 6, 2020 01:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove special case for `simd_shuffle` arg promotion #69280

Remove special case for `simd_shuffle` arg promotion #69280

ecstatic-morse commented Feb 19, 2020

rust-highfive commented Feb 19, 2020

petrochenkov commented Feb 19, 2020

bors commented Feb 19, 2020

petrochenkov commented Feb 19, 2020

ecstatic-morse commented Feb 19, 2020

petrochenkov commented Feb 19, 2020

rust-highfive commented Feb 19, 2020

ecstatic-morse commented Feb 19, 2020

ecstatic-morse commented Feb 19, 2020

bors commented Feb 19, 2020

Remove special case for simd_shuffle arg promotion #69280

Remove special case for simd_shuffle arg promotion #69280

Conversation

ecstatic-morse commented Feb 19, 2020

rust-highfive commented Feb 19, 2020

petrochenkov commented Feb 19, 2020

bors commented Feb 19, 2020

petrochenkov commented Feb 19, 2020

ecstatic-morse commented Feb 19, 2020

petrochenkov commented Feb 19, 2020

rust-highfive commented Feb 19, 2020

ecstatic-morse commented Feb 19, 2020

ecstatic-morse commented Feb 19, 2020

bors commented Feb 19, 2020

Remove special case for `simd_shuffle` arg promotion #69280

Remove special case for `simd_shuffle` arg promotion #69280