ci: switch macOS builders to 10.15 #68863

pietroalbini · 2020-02-05T14:59:39Z

Azure Pipelines is deprecating the macOS 10.13 image we're currently running, and they plan to remove them on March 23, 2020. This PR switches our macOS builders to macOS 10.15.

r? @Mark-Simulacrum

pietroalbini · 2020-02-05T14:59:59Z

@bors try

Let's see what I screwed up.

bors · 2020-02-05T15:00:14Z

⌛ Trying commit ef0bc07e87e4bc50efb54cd3740bad6fc653d6ee with merge bfd963b0b0834db14d326e520e5169b867c996c8...

rust-highfive · 2020-02-05T15:02:32Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-05T15:02:46Z

💔 Test failed - checks-azure

Mark-Simulacrum · 2020-02-05T15:22:44Z

Largely r=me once things start working here; not sure about the python3 change but I presume it's necessary?

pietroalbini · 2020-02-05T15:23:23Z

not sure about the python3 change but I presume it's necessary?

Yep, Python 2 (at least in that location) doesn't exist on 10.15 anymore.

pietroalbini · 2020-02-05T15:45:10Z

@bors try

bors · 2020-02-05T15:45:22Z

⌛ Trying commit 95c55b2 with merge ff69f77...

@Mark-Simulacrum

ci: switch macOS builders to 10.15 Azure Pipelines is deprecating the macOS 10.13 image we're currently running, [and they plan to remove them](https://devblogs.microsoft.com/devops/removing-older-images-in-azure-pipelines-hosted-pools/) on March 23, 2020. This PR switches our macOS builders to macOS 10.15. r? @Mark-Simulacrum

rust-highfive · 2020-02-05T17:44:10Z

The job dist-x86_64-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-05T16:01:48.9204160Z -- Looking for arc4random - found
2020-02-05T16:01:49.0047570Z -- Looking for backtrace
2020-02-05T16:01:49.1913070Z -- Looking for backtrace - found
2020-02-05T16:01:49.1916320Z -- backtrace facility detected in default set of libraries
2020-02-05T16:01:49.1923330Z -- Found Backtrace: /Applications/Xcode_11.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include  
2020-02-05T16:01:49.3706430Z -- Performing Test C_SUPPORTS_WERROR_UNGUARDED_AVAILABILITY_NEW - Success
2020-02-05T16:01:49.3727350Z -- Looking for _Unwind_Backtrace
2020-02-05T16:01:49.5587470Z -- Looking for _Unwind_Backtrace - found
2020-02-05T16:01:49.5606660Z -- Looking for getpagesize
---
2020-02-05T17:02:56.6294000Z -- Detecting C compiler ABI info - done
2020-02-05T17:02:56.6448540Z -- Detecting C compile features
2020-02-05T17:02:56.6455600Z -- Detecting C compile features - done
2020-02-05T17:02:56.6534020Z -- Check for working CXX compiler: /Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++
2020-02-05T17:02:56.8056580Z -- Check for working CXX compiler: /Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++ -- broken
2020-02-05T17:02:56.8058870Z CMake Error at /usr/local/Cellar/cmake/3.16.2/share/cmake/Modules/CMakeTestCXXCompiler.cmake:53 (message):
2020-02-05T17:02:56.8059540Z 
2020-02-05T17:02:56.8060810Z     "/Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++"
2020-02-05T17:02:56.8060990Z 
2020-02-05T17:02:56.8061080Z   is not able to compile a simple test program.
2020-02-05T17:02:56.8061080Z   is not able to compile a simple test program.
2020-02-05T17:02:56.8061140Z 
2020-02-05T17:02:56.8061200Z   It fails with the following output:
2020-02-05T17:02:56.8061260Z 
2020-02-05T17:02:56.8061830Z     Change Dir: /Users/runner/runners/2.164.7/work/1/s/build/x86_64-apple-darwin/native/sanitizers/build/CMakeFiles/CMakeTmp
2020-02-05T17:02:56.8061950Z     
2020-02-05T17:02:56.8062520Z     Run Build Command(s):/usr/bin/make cmTC_47b7c/fast && /Applications/Xcode_11.2.1.app/Contents/Developer/usr/bin/make -f CMakeFiles/cmTC_47b7c.dir/build.make CMakeFiles/cmTC_47b7c.dir/build
2020-02-05T17:02:56.8062680Z     Building CXX object CMakeFiles/cmTC_47b7c.dir/testCXXCompiler.cxx.o
2020-02-05T17:02:56.8063610Z     /Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++    -ffunction-sections -fdata-sections -fPIC --target=x86_64-apple-darwin  -isysroot /Applications/Xcode_11.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.7   -o CMakeFiles/cmTC_47b7c.dir/testCXXCompiler.cxx.o -c /Users/runner/runners/2.164.7/work/1/s/build/x86_64-apple-darwin/native/sanitizers/build/CMakeFiles/CMakeTmp/testCXXCompiler.cxx
2020-02-05T17:02:56.8064810Z     clang-9: warning: include path for libstdc++ headers not found; pass '-stdlib=libc++' on the command line to use the libc++ standard library instead [-Wstdlibcxx-not-found]
2020-02-05T17:02:56.8064940Z     Linking CXX executable cmTC_47b7c
2020-02-05T17:02:56.8065450Z     /usr/local/Cellar/cmake/3.16.2/bin/cmake -E cmake_link_script CMakeFiles/cmTC_47b7c.dir/link.txt --verbose=1
2020-02-05T17:02:56.8066310Z     /Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++   -ffunction-sections -fdata-sections -fPIC --target=x86_64-apple-darwin  -isysroot /Applications/Xcode_11.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.7 -Wl,-search_paths_first -Wl,-headerpad_max_install_names   CMakeFiles/cmTC_47b7c.dir/testCXXCompiler.cxx.o  -o cmTC_47b7c 
2020-02-05T17:02:56.8066860Z     ld: library not found for -lstdc++
2020-02-05T17:02:56.8067320Z     clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
2020-02-05T17:02:56.8067440Z     make[1]: *** [cmTC_47b7c] Error 1
2020-02-05T17:02:56.8067510Z     make: *** [cmTC_47b7c/fast] Error 2
2020-02-05T17:02:56.8067640Z     
2020-02-05T17:02:56.8067680Z 
2020-02-05T17:02:56.8067750Z   
2020-02-05T17:02:56.8067780Z 
2020-02-05T17:02:56.8067780Z 
2020-02-05T17:02:56.8067860Z   CMake will not be able to correctly generate this project.
2020-02-05T17:02:56.8067940Z Call Stack (most recent call first):
2020-02-05T17:02:56.8068010Z   CMakeLists.txt:14 (project)
2020-02-05T17:02:56.8068050Z 
2020-02-05T17:02:56.8068090Z 
2020-02-05T17:02:56.8103700Z -- Configuring incomplete, errors occurred!
2020-02-05T17:02:56.8104320Z See also "/Users/runner/runners/2.164.7/work/1/s/build/x86_64-apple-darwin/native/sanitizers/build/CMakeFiles/CMakeOutput.log".
2020-02-05T17:02:56.8105100Z See also "/Users/runner/runners/2.164.7/work/1/s/build/x86_64-apple-darwin/native/sanitizers/build/CMakeFiles/CMakeError.log".
2020-02-05T17:02:56.8145070Z command did not execute successfully, got: exit code: 1
2020-02-05T17:02:56.8145150Z 
2020-02-05T17:02:56.8145150Z 
2020-02-05T17:02:56.8145680Z build script failed, must exit now', /Users/runner/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/cmake-0.1.42/src/lib.rs:861:5
2020-02-05T17:02:56.8146980Z  finished in 1.008
2020-02-05T17:02:56.8164940Z failed to run: /Users/runner/runners/2.164.7/work/1/s/build/bootstrap/debug/bootstrap dist
2020-02-05T17:02:56.8165170Z Build completed unsuccessfully in 1:11:37
2020-02-05T17:02:56.8215660Z == clock drift check ==
2020-02-05T17:02:56.8215660Z == clock drift check ==
2020-02-05T17:02:56.8243110Z   local time: Wed Feb  5 17:02:56 UTC 2020
2020-02-05T17:02:56.8889380Z   network time: Wed, 05 Feb 2020 17:02:56 GMT
2020-02-05T17:02:56.8891540Z == end clock drift check ==
2020-02-05T17:02:56.8932690Z 
2020-02-05T17:02:56.9030100Z ##[error]Bash exited with code '1'.
2020-02-05T17:02:56.9074930Z ##[section]Starting: Checkout rust-lang/rust@try to s
2020-02-05T17:02:56.9077750Z ==============================================================================
2020-02-05T17:02:56.9077850Z Task         : Get sources
2020-02-05T17:02:56.9077930Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-05T17:44:24Z

💔 Test failed - checks-azure

pietroalbini · 2020-02-06T11:14:42Z

@bors try

bors · 2020-02-06T11:14:56Z

⌛ Trying commit aaf93ab1331f56186e3adb87d926ed262d6f2620 with merge 7572e5cd224068ffd42db9de6f831d93aabc2964...

rust-highfive · 2020-02-06T12:36:01Z

The job dist-x86_64-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-06T11:31:05.7499270Z -- Looking for arc4random - found
2020-02-06T11:31:05.8251150Z -- Looking for backtrace
2020-02-06T11:31:06.0122910Z -- Looking for backtrace - found
2020-02-06T11:31:06.0124540Z -- backtrace facility detected in default set of libraries
2020-02-06T11:31:06.0133120Z -- Found Backtrace: /Applications/Xcode_11.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include  
2020-02-06T11:31:06.1913270Z -- Performing Test C_SUPPORTS_WERROR_UNGUARDED_AVAILABILITY_NEW - Success
2020-02-06T11:31:06.1926730Z -- Looking for _Unwind_Backtrace
2020-02-06T11:31:06.3745950Z -- Looking for _Unwind_Backtrace - found
2020-02-06T11:31:06.3759530Z -- Looking for getpagesize
---
2020-02-06T11:51:29.1177470Z -- Detecting C compiler ABI info - done
2020-02-06T11:51:29.1310340Z -- Detecting C compile features
2020-02-06T11:51:29.1317300Z -- Detecting C compile features - done
2020-02-06T11:51:29.1388620Z -- Check for working CXX compiler: /Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++
2020-02-06T11:51:29.2876950Z -- Check for working CXX compiler: /Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++ -- broken
2020-02-06T11:51:29.2878720Z CMake Error at /usr/local/Cellar/cmake/3.16.2/share/cmake/Modules/CMakeTestCXXCompiler.cmake:53 (message):
2020-02-06T11:51:29.2879260Z 
2020-02-06T11:51:29.2879950Z     "/Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++"
2020-02-06T11:51:29.2880090Z 
2020-02-06T11:51:29.2880180Z   is not able to compile a simple test program.
2020-02-06T11:51:29.2880180Z   is not able to compile a simple test program.
2020-02-06T11:51:29.2880230Z 
2020-02-06T11:51:29.2880300Z   It fails with the following output:
2020-02-06T11:51:29.2880340Z 
2020-02-06T11:51:29.2880890Z     Change Dir: /Users/runner/runners/2.164.7/work/1/s/build/x86_64-apple-darwin/native/sanitizers/build/CMakeFiles/CMakeTmp
2020-02-06T11:51:29.2881000Z     
2020-02-06T11:51:29.2881590Z     Run Build Command(s):/usr/bin/make cmTC_a43a4/fast && /Applications/Xcode_11.2.1.app/Contents/Developer/usr/bin/make -f CMakeFiles/cmTC_a43a4.dir/build.make CMakeFiles/cmTC_a43a4.dir/build
2020-02-06T11:51:29.2881740Z     Building CXX object CMakeFiles/cmTC_a43a4.dir/testCXXCompiler.cxx.o
2020-02-06T11:51:29.2882680Z     /Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++    -ffunction-sections -fdata-sections -fPIC --target=x86_64-apple-darwin  -isysroot /Applications/Xcode_11.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.7   -o CMakeFiles/cmTC_a43a4.dir/testCXXCompiler.cxx.o -c /Users/runner/runners/2.164.7/work/1/s/build/x86_64-apple-darwin/native/sanitizers/build/CMakeFiles/CMakeTmp/testCXXCompiler.cxx
2020-02-06T11:51:29.2883760Z     clang-9: warning: include path for libstdc++ headers not found; pass '-stdlib=libc++' on the command line to use the libc++ standard library instead [-Wstdlibcxx-not-found]
2020-02-06T11:51:29.2883900Z     Linking CXX executable cmTC_a43a4
2020-02-06T11:51:29.2884400Z     /usr/local/Cellar/cmake/3.16.2/bin/cmake -E cmake_link_script CMakeFiles/cmTC_a43a4.dir/link.txt --verbose=1
2020-02-06T11:51:29.2885290Z     /Users/runner/runners/2.164.7/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang++   -ffunction-sections -fdata-sections -fPIC --target=x86_64-apple-darwin  -isysroot /Applications/Xcode_11.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.7 -Wl,-search_paths_first -Wl,-headerpad_max_install_names   CMakeFiles/cmTC_a43a4.dir/testCXXCompiler.cxx.o  -o cmTC_a43a4 
2020-02-06T11:51:29.2885860Z     ld: library not found for -lstdc++
2020-02-06T11:51:29.2886310Z     clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
2020-02-06T11:51:29.2886430Z     make[1]: *** [cmTC_a43a4] Error 1
2020-02-06T11:51:29.2886510Z     make: *** [cmTC_a43a4/fast] Error 2
2020-02-06T11:51:29.2886640Z     
2020-02-06T11:51:29.2886680Z 
2020-02-06T11:51:29.2886730Z   
2020-02-06T11:51:29.2886780Z 
2020-02-06T11:51:29.2886780Z 
2020-02-06T11:51:29.2886850Z   CMake will not be able to correctly generate this project.
2020-02-06T11:51:29.2887370Z Call Stack (most recent call first):
2020-02-06T11:51:29.2887480Z   CMakeLists.txt:14 (project)
2020-02-06T11:51:29.2887540Z 
2020-02-06T11:51:29.2887570Z 
2020-02-06T11:51:29.2923760Z -- Configuring incomplete, errors occurred!
2020-02-06T11:51:29.2924330Z See also "/Users/runner/runners/2.164.7/work/1/s/build/x86_64-apple-darwin/native/sanitizers/build/CMakeFiles/CMakeOutput.log".
2020-02-06T11:51:29.2924970Z See also "/Users/runner/runners/2.164.7/work/1/s/build/x86_64-apple-darwin/native/sanitizers/build/CMakeFiles/CMakeError.log".
2020-02-06T11:51:29.2969040Z command did not execute successfully, got: exit code: 1
2020-02-06T11:51:29.2969120Z 
2020-02-06T11:51:29.2969120Z 
2020-02-06T11:51:29.2969900Z build script failed, must exit now', /Users/runner/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/cmake-0.1.42/src/lib.rs:861:5
2020-02-06T11:51:29.2971190Z  finished in 0.892
2020-02-06T11:51:29.2986690Z failed to run: /Users/runner/runners/2.164.7/work/1/s/build/bootstrap/debug/bootstrap dist
2020-02-06T11:51:29.2986840Z Build completed unsuccessfully in 0:30:47
2020-02-06T11:51:29.3037340Z == clock drift check ==
2020-02-06T11:51:29.3037340Z == clock drift check ==
2020-02-06T11:51:29.3084440Z   local time: Thu Feb  6 11:51:29 UTC 2020
2020-02-06T11:51:29.3407790Z   network time: Thu, 06 Feb 2020 11:51:29 GMT
2020-02-06T11:51:29.3413870Z == end clock drift check ==
2020-02-06T11:51:29.3508890Z 
2020-02-06T11:51:29.3612100Z ##[error]Bash exited with code '1'.
2020-02-06T11:51:29.3660350Z ##[section]Starting: Checkout rust-lang/rust@try to s
2020-02-06T11:51:29.3663430Z ==============================================================================
2020-02-06T11:51:29.3663540Z Task         : Get sources
2020-02-06T11:51:29.3663610Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-06T12:36:14Z

💔 Test failed - checks-azure

ehuss · 2020-02-09T01:44:13Z

Have you been able to run all tests on 10.15?

I'm having problems with Cargo's test suite failing because processes are getting killed by the OS. 75% of my azure runs have failed so far. It looks like some error with Gatekeeper, I see these messages in the logs:

Logs

taskgated   11  libsystem_pthread.dylib             0x00007fff6522fe65 _pthread_start + 148
taskgated   12  libsystem_pthread.dylib             0x00007fff6522b83b thread_start + 15
taskgated   no system signature for unsigned /Users/eric/Proj/rust/cargo/target/debug/cargo[30241]
taskgated   close(3) err: 0
taskgated   end request
taskgated   begin request: 3331, 27001
taskgated   UNIX error exception: 2
opendirectoryd  PID: 30240, Client: 'clang', exited with 0 session(s), 0 node(s) and 0 active request(s)
opendirectoryd  Trigger - cancelled
opendirectoryd  Finalizing pidinfo (30240) object - 0x7fccecb44d00
taskgated   0   Security                            0x00007fff3a1fea43 Security::CommonError::LogBacktrace() + 107
taskgated   1   Security                            0x00007fff3a1fed5d Security::UnixError::UnixError(int, bool) + 263
taskgated   2   Security                            0x00007fff3a1fedb8 Security::UnixError::throwMe(int) + 36
taskgated   3   Security                            0x00007fff3a101c56 Security::CodeSigning::KernelCode::identifyGuest(Security::CodeSigning::SecCode*, __CFData const**) + 1006
taskgated   4   Security                            0x00007fff3a0df0fa Security::CodeSigning::SecCode::identify() + 58
taskgated   5   Security                            0x00007fff3a0df514 Security::CodeSigning::SecCode::autoLocateGuest(__CFDictionary const*, unsigned int) + 122
taskgated   6   Security                            0x00007fff3a0e55a6 SecCodeCopyGuestWithAttributes + 78
taskgated   7   taskgated                           0x000000010119f3b7 taskgated + 13239
taskgated   8   taskgated                           0x000000010119facb taskgated + 15051
taskgated   9   taskgated                           0x000000010119fe67 taskgated + 15975
taskgated   10  taskgated                           0x000000010119fed3 taskgated + 16083
taskgated   11  taskgated                           0x00000001011a20ea taskgated + 24810
taskgated   12  taskgated                           0x00000001011a1617 taskgated + 22039
opendirectoryd  PID: 30005, Client: 'cargo', exited with 0 session(s), 0 node(s) and 0 active request(s)
taskgated   13  taskgated                           0x00000001011a0ce5 taskgated + 19685
syspolicyd  GK process assessment:  <-- (, )
opendirectoryd  Trigger - cancelled
syspolicyd  Unable (errno: 2) to read file at  for process path:  library path: (null)
taskgated   14  libsystem_pthread.dylib             0x00007fff6522fe65 _pthread_start + 148
opendirectoryd  Finalizing pidinfo (30005) object - 0x7fccead43440
syspolicyd  Dropping com.apple.syspolicy.Gatekeeper.Errors as it isn't used in any transform (not in the config or budgeted?)
kernel  build_userspace_exit_reason: illegal flags passed from userspace (some masked off) 0x141, ns: 9, code 0x8
syspolicyd  Terminating process due to Gatekeeper rejection: 30005, 
taskgated   15  libsystem_pthread.dylib             0x00007fff6522b83b thread_start + 15
kernel  Waking up reference: 66615
taskgated   no signature for pid=30005 (cannot make code: UNIX[No such file or directory])
kernel  Thread waiting on reference 66615 woke up
taskgated   end request
kernel  Sleep interrupted, signal 0x100
kernel  Security policy would not allow process: 30005, /Users/eric/Proj/rust/cargo/target/cit/t1430/foo/target/debug/deps/foo

The key part is "Terminating process due to Gatekeeper rejection". The exception just above it is also unique to this error.

I tried to repro with compiletest, but I wasn't able to. I figure since the run-pass tests quickly generate a large number of new executables it would maybe have the same problem.

I'm a little concerned because I have no idea how to fix this. I suspect this is just a bug in Gatekeeper. Cargo's test suite could maybe check for processes killed with sigkill and restart them? I'm not sure if rust's test suite will be impacted by this on azure (I don't think my free account can build and run rustc, so I can't experiment).

pietroalbini · 2020-02-12T15:20:22Z

cc @Mark-Simulacrum

rye · 2020-02-12T15:59:23Z

Linking against libstdc++ is apparently no longer supported with Xcode 10+ (emphasis mine):

Building with libstdc++ was deprecated with Xcode 8 and is not supported in Xcode 10 when targeting iOS. C++ projects must now migrate to libc++ and are recommended to set a deployment target of macOS 10.9 or later, or iOS 7 or later. Besides changing the C++ Standard Library build setting, developers should audit hard-coded linker flags and target dependencies to remove references to libstdc++ (including -lstdc++, -lstdc++.6.0.9, libstdc++.6.0.9.tbd, and libstdc++.6.0.9.dylib). Project dependencies such as static archives that were built against libstdc++ will also need to be rebuilt against libc++.

The issue (I believe) is that the cmake invocation for the compiler-rt target includes "-DCOMPILER_RT_USE_LIBCXX=OFF", which is explicitly added during bootstrapping:

rust/src/bootstrap/native.rs

Line 610 in 4ff8fb9

cfg.define("COMPILER_RT_USE_LIBCXX", "OFF");

It looks like when this flag was added (to compiler-rt) it was set to ON by default, so perhaps removing the explicit set to "OFF" would help? That'd be something to try, at least. I couldn't find any mention of the flag (COMPILER_RT_USE_LIBCXX) in any issues or PRs, it was just added as part of the Sanitizers step in ae57259 (part of #65241) with a few additional configurations.

pietroalbini · 2020-02-12T17:44:41Z

Thanks @rye!

Looking a bit into it, it makes sense that the failure was caused by that line/PR: my GitHub Actions branch (which has a mostly similar configuration and environment) was building fine before the last rebase, while it failed to build with the same error after I rebased on the latest master.

Let's see if everything works fine with that patch.
@bors try

cc @tmiasko (author of #65241) and @alexcrichton (reviewer of #65241)

pietroalbini · 2020-02-17T11:22:13Z

@bors try

bors · 2020-02-17T11:22:23Z

⌛ Trying commit 592bc1b033b22acabaa4c6d1ff3d3b20b72a0201 with merge 6bddff650254c446c55efe5f4ab1d3725c5493cc...

bors · 2020-02-17T13:03:37Z

☀️ Try build successful - checks-azure
Build commit: 6bddff650254c446c55efe5f4ab1d3725c5493cc (6bddff650254c446c55efe5f4ab1d3725c5493cc)

pietroalbini · 2020-02-17T13:49:53Z

Great! It works.

r? @Mark-Simulacrum
@rustbot modify labels: beta-nominated T-infra

Mark-Simulacrum · 2020-02-19T14:02:36Z

@bors r+ rollup=never

(Feel free to prioritize, but I think we have enough slack time that it's hopefully not necessary).

bors · 2020-02-19T14:02:38Z

📌 Commit 79c166e has been approved by Mark-Simulacrum

pietroalbini · 2020-02-19T14:03:43Z

We actually did a try run with the affected builders and it was successful, so let's allow rolling this PR up.

@bors rollup

ehuss · 2020-02-19T14:54:54Z

I would be concerned that without Cargo fixed, this will cause frequent failures. I'm not sure if the rust-lang macos machines are different enough to make much of a difference, but on the free microsoft hosted ones I saw a lot of errors.

@Mark-Simulacrum

…ark-Simulacrum ci: switch macOS builders to 10.15 Azure Pipelines is deprecating the macOS 10.13 image we're currently running, [and they plan to remove them](https://devblogs.microsoft.com/devops/removing-older-images-in-azure-pipelines-hosted-pools/) on March 23, 2020. This PR switches our macOS builders to macOS 10.15. r? @Mark-Simulacrum

pietroalbini · 2020-02-19T17:19:03Z

@ehuss we don't really have a choice, as Azure Pipelines is dropping the macOS 10.13 images on March 23rd.

ehuss · 2020-02-19T17:25:37Z

That's a month away? We're working on a fix now, I don't expect it to take that long.

If this merges now, there is a chance that the majority of PRs will fail. Have you done multiple tests on the rust-lang builders to see what the error rate is?

pietroalbini · 2020-02-19T17:59:05Z

That's a month away? We're working on a fix now, I don't expect it to take that long.

I'd prefer to have things in place in advance, to avoid rushing things in the last minute.

If this merges now, there is a chance that the majority of PRs will fail. Have you done multiple tests on the rust-lang builders to see what the error rate is?

We did a couple of try builds in this PR and never got such failure (neither in the GHA configuration, which should be mostly the same). If this ends up causing spurious failures we can always revert.

@ghost

Rollup of 5 pull requests Successful merges: - #68863 (ci: switch macOS builders to 10.15) - #69142 (Add shared script for linkchecking books.) - #69248 (Don't eliminate frame pointers on thumb targets) - #69280 (Remove special case for `simd_shuffle` arg promotion) - #69284 (Reword OpenOptions::{create, create_new} doc.) Failed merges: r? @ghost

@ghost

[beta] backports This backports the following PRs: * ci: switch macOS builders to 10.15 #68863 * Backport release notes of 1.41.1 #69468 * Cherry-pick the LLVM fix for #69225 #69450 * `lit_to_const`: gracefully bubble up type errors. #69330 * [beta] bootstrap from 1.41.1 stable #69518 * bootstrap: Configure cmake when building sanitizer runtimes #69104 r? @ghost

rust-highfive assigned Mark-Simulacrum Feb 5, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2020

pietroalbini force-pushed the azure-macos-10.15 branch from ef0bc07 to 95c55b2 Compare February 5, 2020 15:43

pietroalbini force-pushed the azure-macos-10.15 branch from 95c55b2 to aaf93ab Compare February 6, 2020 11:07

ehuss mentioned this pull request Feb 9, 2020

Update CI for upcoming macOS changes rust-lang/cargo#7821

Closed

pietroalbini force-pushed the azure-macos-10.15 branch 2 times, most recently from 7743930 to 625c9cd Compare February 12, 2020 17:41

pietroalbini force-pushed the azure-macos-10.15 branch from 592bc1b to 79c166e Compare February 17, 2020 13:46

rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 17, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2020

This was referenced Feb 19, 2020

Rollup of 5 pull requests #69292

Closed

Rollup of 5 pull requests #69293

Merged

bors merged commit 2f914bf into rust-lang:master Feb 19, 2020

pietroalbini deleted the azure-macos-10.15 branch February 20, 2020 07:48

pietroalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 26, 2020

Mark-Simulacrum mentioned this pull request Feb 28, 2020

[beta] backports #69535

Merged

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 28, 2020

ehuss mentioned this pull request Mar 10, 2020

Compiler selects invalid --lldb-python path #69869

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: switch macOS builders to 10.15 #68863

ci: switch macOS builders to 10.15 #68863

pietroalbini commented Feb 5, 2020

pietroalbini commented Feb 5, 2020

bors commented Feb 5, 2020

rust-highfive commented Feb 5, 2020

bors commented Feb 5, 2020

Mark-Simulacrum commented Feb 5, 2020

pietroalbini commented Feb 5, 2020

pietroalbini commented Feb 5, 2020

bors commented Feb 5, 2020

rust-highfive commented Feb 5, 2020

bors commented Feb 5, 2020

pietroalbini commented Feb 6, 2020

bors commented Feb 6, 2020

rust-highfive commented Feb 6, 2020

bors commented Feb 6, 2020

ehuss commented Feb 9, 2020

pietroalbini commented Feb 12, 2020

rye commented Feb 12, 2020 •

edited

Loading

pietroalbini commented Feb 12, 2020

pietroalbini commented Feb 17, 2020

bors commented Feb 17, 2020

bors commented Feb 17, 2020

pietroalbini commented Feb 17, 2020

Mark-Simulacrum commented Feb 19, 2020

bors commented Feb 19, 2020

pietroalbini commented Feb 19, 2020

ehuss commented Feb 19, 2020

pietroalbini commented Feb 19, 2020

ehuss commented Feb 19, 2020

pietroalbini commented Feb 19, 2020

ci: switch macOS builders to 10.15 #68863

ci: switch macOS builders to 10.15 #68863

Conversation

pietroalbini commented Feb 5, 2020

pietroalbini commented Feb 5, 2020

bors commented Feb 5, 2020

rust-highfive commented Feb 5, 2020

bors commented Feb 5, 2020

Mark-Simulacrum commented Feb 5, 2020

pietroalbini commented Feb 5, 2020

pietroalbini commented Feb 5, 2020

bors commented Feb 5, 2020

rust-highfive commented Feb 5, 2020

bors commented Feb 5, 2020

pietroalbini commented Feb 6, 2020

bors commented Feb 6, 2020

rust-highfive commented Feb 6, 2020

bors commented Feb 6, 2020

ehuss commented Feb 9, 2020

pietroalbini commented Feb 12, 2020

rye commented Feb 12, 2020 • edited Loading

pietroalbini commented Feb 12, 2020

pietroalbini commented Feb 17, 2020

bors commented Feb 17, 2020

bors commented Feb 17, 2020

pietroalbini commented Feb 17, 2020

Mark-Simulacrum commented Feb 19, 2020

bors commented Feb 19, 2020

pietroalbini commented Feb 19, 2020

ehuss commented Feb 19, 2020

pietroalbini commented Feb 19, 2020

ehuss commented Feb 19, 2020

pietroalbini commented Feb 19, 2020

rye commented Feb 12, 2020 •

edited

Loading