Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler-builtins to 0.1.25 #69086

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Feb 12, 2020

Fixes #68794.

Tested in CI: #69045.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2020
@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2020

📌 Commit ee85e91 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 12, 2020
…n-DPC

Update compiler-builtins to 0.1.25

- rust-lang/compiler-builtins#340 Set probestack visibility to hidden on ELF targets

Fixes rust-lang#68794.

Tested in CI: rust-lang#69045.

r? @Mark-Simulacrum
bors added a commit that referenced this pull request Feb 12, 2020
Rollup of 7 pull requests

Successful merges:

 - #67954 (Support new LLVM pass manager)
 - #68981 ( Account for type params on method without parentheses)
 - #69002 (miri: improve and simplify overflow detection)
 - #69038 (Add initial debug fmt for Backtrace)
 - #69040 (Cleanup SGX entry code)
 - #69086 (Update compiler-builtins to 0.1.25)
 - #69095 (Minified theme check)

Failed merges:

r? @ghost
@tmandry tmandry added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 13, 2020
@tmandry
Copy link
Member Author

tmandry commented Feb 13, 2020

Adding beta nomination, see also rust-lang/compiler-builtins#340 (comment)

@bors bors merged commit ee85e91 into rust-lang:master Feb 13, 2020
@tmandry tmandry deleted the probestack-hidden-2 branch February 14, 2020 06:30
@Mark-Simulacrum Mark-Simulacrum added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 3, 2020
@Mark-Simulacrum
Copy link
Member

beta-nominated #69168 as well since that has a test for this fix

@pnkfelix
Copy link
Member

pnkfelix commented Mar 5, 2020

discussed in T-compiler meeting. beta-accepted

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 5, 2020
bors added a commit that referenced this pull request Mar 6, 2020
[beta] another round of backports for 1.42

This backports the following pull requests:

* Fix a leak in `DiagnosticBuilder::into_diagnostic`. #69628
* stash API: remove panic to fix ICE. #69623
* Do not ICE on invalid type node after parse recovery #69583
* Backport only: avoid ICE on bad placeholder type #69324
* add regression test for issue #68794 #69168
* Update compiler-builtins to 0.1.25 #69086
* Update RELEASES.md for 1.42.0 #68989
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEXTREL in i686 since 1.41.0
7 participants