-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for type params on method without parentheses #68981
Conversation
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
The second commit can be reverted if it is too intrusive for too small a gain. |
Looks like the second comment also makes fields with generic arguments legal under |
@petrochenkov adding delay_span_bug would help with accidental stabilization, but not be a good experience. Is there a place where this check could be done even if cfged out? |
@bors r=davidtwco |
📌 Commit 9d91489 has been approved by |
Account for type params on method without parentheses Account for those type parameters in the structured suggestion when forgetting to call method: ``` error[E0615]: attempted to take value of method `collect` on type `std::vec::IntoIter<_>` --> $DIR/method-missing-parentheses.rs:2:32 | LL | let _ = vec![].into_iter().collect::<usize>; | ^^^^^^^--------- | | | help: use parentheses to call the method: `collect::<usize>()` ```
Rollup of 7 pull requests Successful merges: - #67954 (Support new LLVM pass manager) - #68981 ( Account for type params on method without parentheses) - #69002 (miri: improve and simplify overflow detection) - #69038 (Add initial debug fmt for Backtrace) - #69040 (Cleanup SGX entry code) - #69086 (Update compiler-builtins to 0.1.25) - #69095 (Minified theme check) Failed merges: r? @ghost
Account for those type parameters in the structured suggestion when forgetting to call method: