Add GitHub issue templates

[XAMPPRocky]

This PR adds GitHub's issue templates to the repository. Adding templates for two of the most common issues we create on the repository. We could add more specific templates (e.g. ICEs) depending on the response to initial templates. I've included a screenshot of what it looks like, and people can also try out the UI and specific templates, by going to XAMPPRocky/rust.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[XAMPPRocky]

r? @Mark-Simulacrum

[hellow554]

What about using @rustbot to modify the labels, e.g. a tracking issue should have the tracking-issue label

[Mark-Simulacrum]

As the primary "source" / "destination" of issues, nominating for compiler team. I am primarily interested in anyone who is strongly opposed to this change -- if there's anyone with opposition, we should make sure to meet their needs before merging.

I would also like feedback from the Cargo team, so nominating there as well -- I believe Cargo uses templates on the rust-lang/cargo repository, and am interested in knowing how that has gone for you.

---

I myself am not entirely sure that this is going to be a net win for us, but could see that being the case. I think landing makes sense, in an experimental sense (we can remove if they don't seem to help).

[XAMPPRocky]

@hellow554 That's already done and part of GitHub's templates as you can see here. So they'll automatically have C-tracking-issue or C-bug. https://github.com/rust-lang/rust/pull/68413/files#diff-b146d1c543dd5f77a89bd8026dd56b10

[steveklabnik]

I like this idea! I think an ICE one would be great. Tracking issue feels kinda weird to me, given that only certain people open them at certain times, but I'm not horribly opposed.

[XAMPPRocky]

@steveklabnik The fact that only certain people open them is actually part of the motivation for this template. Right now we don't actually have documentation on how to make a tracking issue, and as such they only specific people create them.

Anyone on a team should be able to create a tracking issue, there's no reason it should be blocked on a lead/shepherd doing the work. This template should hopefully act as both documentation on how to create a tracking issue as well as making the work more easily delegate-able to other members on team.

[Mark-Simulacrum]

We do have documentation for tracking issues: https://forge.rust-lang.org/lang/rfc-merge-procedure.html#step-1-open-tracking-issue.

[XAMPPRocky]

@Mark-Simulacrum Ah, nice. I've now included that in the template.

[ehuss]

Seems like a good idea to me. I think templates have improved the quality of reports on the Cargo repo. I think it is important that the templates be concise (nobody likes to fill out a long form), and this seems to hit a good balance.

[spastorino]

@XAMPPRocky I like this idea, I wonder if we can make https://github.com/rust-lang/cargo-bisect-rustc adhere better to this or we can use here and there the same format.

[XAMPPRocky]

@spastorino I believe we can share with all repositories by having them in https://github.com/rust-lang/.github, but I don't know if there's an easy way to share between individual repositories. Of course we can also just copy it.

[spastorino]

@XAMPPRocky I was referring more to the output of the tool, that emits a report to be pasted on Github. Check this rust-lang/cargo-bisect-rustc#41 out. You can check how the report looks here spastorino/cargo-bisect-sample#1. I'm wondering if we can connect in some way that report with this templates but as the very minimum we should use the same format. Probably yours is better :).

[XAMPPRocky]

@spastorino Ah okay, we could have something like the following, where the link leads you to the template and you paste in the info generated by the tool.

==================================================================================
= Please open an issue on Rust's github repository                               =
= https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
= Below you will find a text that would serve as a starting point of your report =
==================================================================================

# Regression found in the compiler

searched nightlies: from nightly-2019-09-29 to nightly-2019-09-30
regressed nightly: nightly-2019-09-30
searched commits: from https://github.com/rust-lang/rust/commit/488381ce9ef0ceabe83b73127c659e5d38137df0 to https://github.com/rust-lang/rust/commit/8431f261dd160021b6af85916f161a13dd101ca0
regressed commit: https://github.com/rust-lang/rust/commit/0bbab7d99dde8620604fb265706dc8bff20345a7
source code: URL OF A REPOSITORY THAT REPRODUCES THE ERROR

[spastorino]

Yeah it could be but it would need a special template because regressions are not necessarily ICEs. Maybe we can just have a regression template and do what you're saying from the tool.

[XAMPPRocky]

@spastorino I'd have no problem with another template for regressions, and linking that.

[Mark-Simulacrum]

Okay, let's merge this in, and we can iterate (or back this out) depending on what folks think. @XAMPPRocky Can we try to post something on users or internals in 2 weeks or so to ask for feedback on the templates?

[Mark-Simulacrum]

@bors r+ rollup

[bors]

📌 Commit 49d78fc has been approved by Mark-Simulacrum

[XAMPPRocky]

@Mark-Simulacrum Since two weeks from now there is a release team meeting, can we add it to the agenda for that meeting?