Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thinning pointers to extern types in miri #50530

Merged
merged 1 commit into from
May 8, 2018
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 8, 2018

r? @kennytm as an alternative to disabling the miri build

fixes #50495

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2018
@kennytm
Copy link
Member

kennytm commented May 8, 2018

@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 8, 2018

📌 Commit 5258871 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2018
@kennytm
Copy link
Member

kennytm commented May 8, 2018

@bors p=7

@bors
Copy link
Contributor

bors commented May 8, 2018

⌛ Testing commit 5258871 with merge 8ff4b42...

bors added a commit that referenced this pull request May 8, 2018
Fix thinning pointers to extern types in miri

r? @kennytm as an alternative to disabling the miri build

fixes #50495
@bors
Copy link
Contributor

bors commented May 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 8ff4b42 to master...

@bors bors merged commit 5258871 into rust-lang:master May 8, 2018
@oli-obk oli-obk deleted the miri branch May 8, 2018 20:36
@kennytm-githubbot
Copy link

📣 Toolstate changed by #50530!

Tested on commit 8ff4b42.
Direct link to PR: #50530

🎉 miri on windows: build-fail → test-pass.
🎉 miri on linux: build-fail → test-pass.

kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 8, 2018
Tested on commit rust-lang/rust@8ff4b42.
Direct link to PR: <rust-lang/rust#50530>

🎉 miri on windows: build-fail → test-pass.
🎉 miri on linux: build-fail → test-pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miri crashes on fat ptr to thin ptr conversion
5 participants