Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Prepare the 1.27.0 beta release #50522

Merged
merged 1 commit into from
May 9, 2018
Merged

[beta] Prepare the 1.27.0 beta release #50522

merged 1 commit into from
May 9, 2018

Conversation

alexcrichton
Copy link
Member

This commit prepares the 1.27.0 beta release by doing:

  • Update the release channel to beta
  • Update Cargo's submodule
  • Update stdsimd's submodule
  • Update the bootstrap compiler to the freshly minted 1.26.0 stable release

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2018
@alexcrichton
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented May 8, 2018

📌 Commit 899e5f3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2018
@bors
Copy link
Contributor

bors commented May 8, 2018

⌛ Testing commit 899e5f31279b09cadf5e4fec9d6bdcae0f74e126 with merge acc10674dcd3bc68153a802ba71ed8648344a875...

@bors
Copy link
Contributor

bors commented May 8, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 8, 2018
@kennytm
Copy link
Member

kennytm commented May 8, 2018 

{"miri":"build-fail","rls":"build-fail","reference":"test-pass","rustfmt":"test-fail","book":"test-pass","rust-by-example":"test-pass","nomicon":"test-pass","clippy-driver":"build-fail"}

Legit, tools are failing. I suggest we wait until #50503 is merged (and update this PR), and also disable the miri check.

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2018
@oli-obk
Copy link
Contributor

oli-obk commented May 8, 2018

#50503 has been merged. As an alternative to disabling the miri check, there's #50530 fixing miri (very small diff (5 lines + a new test))

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 8, 2018
@alexcrichton
Copy link
Member Author

The error here is a bit confusing, but the real issue is that rustfmt's tests are failing, not clippy/miri

@alexcrichton
Copy link
Member Author

The rustfmt fix is at rust-lang/rustfmt#2685 and the rls fix is at rust-lang/rls#854

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 8, 2018
@kennytm
Copy link
Member

kennytm commented May 8, 2018

#50530 and rust-lang/rls#854 are merged. Still waiting for rust-lang/rustfmt#2685.

@nrc
Copy link
Member

nrc commented May 8, 2018

Rustfmt is fix is merged

@alexcrichton
Copy link
Member Author

@bors: r+

Thanks @nrc!

@bors
Copy link
Contributor

bors commented May 8, 2018

📌 Commit c5650c1 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 8, 2018
@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented May 9, 2018

📌 Commit 1eb2801 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2018
@bors
Copy link
Contributor

bors commented May 9, 2018

⌛ Testing commit 1eb2801b39c516939f3f1dbbb3432e0201bda838 with merge d12292a85f677c1d10f0dd8b25589c4afa877ab4...

@bors
Copy link
Contributor

bors commented May 9, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2018
@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented May 9, 2018

📌 Commit bec1d45 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2018
@bors
Copy link
Contributor

bors commented May 9, 2018

⌛ Testing commit bec1d45febbbba07f2975c42db8b3ab069cfcfa3 with merge ef814f1900ec3967c687b7647c45c80efb65a6f9...

@bors
Copy link
Contributor

bors commented May 9, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2018
@alexcrichton
[beta] Prepare the 1.27.0 beta release
4d4e96d 
This commit prepares the 1.27.0 beta release by doing:

* Update the release channel to `beta`
* Update Cargo's submodule
* Update `stdsimd`'s submodule
* Update the bootstrap compiler to the freshly minted 1.26.0 stable release
* Don't attempt to verify clippy/miri build
@alexcrichton
Copy link
Member Author

Getting real tired of this. Filed #50557.

@bors: r+

@bors
Copy link
Contributor

bors commented May 9, 2018

📌 Commit 4d4e96d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2018
@bors
Copy link
Contributor

bors commented May 9, 2018

⌛ Testing commit 4d4e96d with merge 03fb2f4...

bors added a commit that referenced this pull request May 9, 2018
@bors
Auto merge of #50522 - alexcrichton:beta-next, r=alexcrichton
03fb2f4 
[beta] Prepare the 1.27.0 beta release

This commit prepares the 1.27.0 beta release by doing:

* Update the release channel to `beta`
* Update Cargo's submodule
* Update `stdsimd`'s submodule
* Update the bootstrap compiler to the freshly minted 1.26.0 stable release
@bors
Copy link
Contributor

bors commented May 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 03fb2f4 to beta...

@bors bors merged commit 4d4e96d into rust-lang:beta May 9, 2018
@alexcrichton alexcrichton deleted the beta-next branch June 29, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexcrichton @rust-highfive @bors @kennytm @oli-obk @nrc @aturon