Add Span to ast::WhereClause #43501
Merged
Add Span to ast::WhereClause #43501
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
added
the
S-waiting-on-review
nrc
approved these changes
Jul 28, 2017
| @@ -216,6 +216,7 @@ fn mk_generics(lifetimes: Vec<ast::LifetimeDef>, ty_params: Vec<ast::TyParam>, s | |||
| where_clause: ast::WhereClause { | |||
| id: ast::DUMMY_NODE_ID, | |||
| predicates: Vec::new(), | |||
| span: DUMMY_SP, | |||
There was a problem hiding this comment.
Should use span here rather than DUMMY_SP
topecongiro
force-pushed
the
span-to-whereclause
branch
from
76634d7 to
6375b77
Compare
|
Rebased. |
|
@bors r=nrc |
|
📌 Commit 6375b77 has been approved by |
|
@bors rollup |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Jul 29, 2017
Add Span to ast::WhereClause This PR adds `Span` field to `ast::WhereClause`. The motivation here is to make rustfmt's life easier when recovering comments before and after where clause. r? @nrc
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 30, 2017
Add Span to ast::WhereClause This PR adds `Span` field to `ast::WhereClause`. The motivation here is to make rustfmt's life easier when recovering comments before and after where clause. r? @nrc
bors
added a commit
that referenced
this pull request
Jul 30, 2017
|
@bors p=-2 (unblock bors) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Spanfield toast::WhereClause. The motivation here is to make rustfmt's life easier when recovering comments before and after where clause.r? @nrc