Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make into_iter example more concise #43409

Merged
merged 1 commit into from
Jul 30, 2017
Merged

doc: make into_iter example more concise #43409

merged 1 commit into from
Jul 30, 2017

Conversation

tshepang
Copy link
Member

Also, remove dupe example

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2017
@steveklabnik
Copy link
Member

The example is duplicated on purpose, so that each thing has its own docs with examples.

I don't have any particular feelings about making it more concise, but the build is failing.

@tshepang
Copy link
Member Author

looks like a spurious failure

@tshepang
Copy link
Member Author

I will leave it duplicated then

@alexcrichton
Copy link
Member

r? @steveklabnik

Mind reviewing this Steve?

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Jul 27, 2017
@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 28, 2017

📌 Commit 42dae9d has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jul 29, 2017
@frewsxcv
Rollup merge of rust-lang#43409 - tshepang:concise, r=steveklabnik
9f93319 
doc: make into_iter example more concise

Also, remove dupe example
@frewsxcv frewsxcv mentioned this pull request Jul 29, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 30, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#43409 - tshepang:concise, r=steveklabnik
f205f48 
doc: make into_iter example more concise

Also, remove dupe example
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 30, 2017
Merged
bors added a commit that referenced this pull request Jul 30, 2017
@bors
Auto merge of #43551 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
5c71e4e 
Rollup of 8 pull requests

- Successful merges: #43409, #43501, #43509, #43512, #43513, #43536, #43544, #43549
- Failed merges:
@bors bors merged commit 42dae9d into rust-lang:master Jul 30, 2017
@tshepang tshepang deleted the concise branch July 30, 2017 06:41
@kennytm
Copy link
Member

kennytm commented Jul 31, 2017

@bors p=-2 (unblock bors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tshepang @rust-highfive @steveklabnik @alexcrichton @bors @kennytm @brson @carols10cents