Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #42032

Closed
wants to merge 23 commits into from

Commits on May 13, 2017

  1. Add lint for unused macros

    est31 committed May 13, 2017
    Configuration menu
    Copy the full SHA
    df188b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db82c57 View commit details
    Browse the repository at this point in the history
  3. Support #[allow] etc logic on a per macro level

    This commit extends the current unused macro linter
    to support directives like #[allow(unused_macros)]
    or #[deny(unused_macros)] directly next to the macro
    definition, or in one of the modules the macro is
    inside. Before, we only supported such directives
    at a per crate level, due to the crate's NodeId
    being passed to session.add_lint.
    
    We also had to implement handling of the macro's
    NodeId in the lint visitor.
    est31 committed May 13, 2017
    Configuration menu
    Copy the full SHA
    d14d194 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ba0601d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b36d23c View commit details
    Browse the repository at this point in the history

Commits on May 14, 2017

  1. Configuration menu
    Copy the full SHA
    0d0cb27 View commit details
    Browse the repository at this point in the history
  2. Explain why thread::yield_now could be used.

    Felix Raimundo committed May 14, 2017
    Configuration menu
    Copy the full SHA
    a9cb094 View commit details
    Browse the repository at this point in the history
  3. Improve thread::Builder documentation.

    Part of rust-lang#29378 .
    
    - In particular explains *why* we would use the builder instead of
      the free function.
    - Changes the parent-child explanation for a spawned-caller.
    - Add link to `io::Result` in `thread::Builder`
    - Corrects the `thread::Builder::spawn` documentation.
    Felix Raimundo committed May 14, 2017
    Configuration menu
    Copy the full SHA
    a51777e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    93f78bc View commit details
    Browse the repository at this point in the history

Commits on May 15, 2017

  1. Configuration menu
    Copy the full SHA
    173f693 View commit details
    Browse the repository at this point in the history
  2. Make unsatisfied trait bounds note multiline

    Make diagnostic note for existing method with unsatisfied trait bounds
    multiline for cleaner output.
    
    ```
      = note: the method `count` exists but the following trait bounds were not satisfied:
              `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`
              `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>> [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
    
    Before:
    
    ```
      = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
    ```
    estebank committed May 15, 2017
    Configuration menu
    Copy the full SHA
    c0d5aa8 View commit details
    Browse the repository at this point in the history
  3. Address review comments

    est31 committed May 15, 2017
    Configuration menu
    Copy the full SHA
    25b7f10 View commit details
    Browse the repository at this point in the history
  4. Add links to the thread::LocalKey doc.

    Part of rust-lang#29378 .
    Felix Raimundo committed May 15, 2017
    Configuration menu
    Copy the full SHA
    f92bd3d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9f4e1e1 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2017

  1. Configuration menu
    Copy the full SHA
    6dbd706 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#41489 - estebank:trait-bounds-diagnosstic, …

    …r=arielb1
    
    Make unsatisfied trait bounds note multiline
    
    Make diagnostic note for existing method with unsatisfied trait bounds
    multiline for cleaner output.
    
    ```
      = note: the method `count` exists but the following trait bounds were not satisfied:
              `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`
              `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>> [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
    ```
    
    Before:
    
    ```
      = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
    ```
    Mark-Simulacrum authored May 16, 2017
    Configuration menu
    Copy the full SHA
    a49d6c1 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#41907 - est31:macro_unused, r=jseyfried

    Add lint for unused macros
    
    Addresses parts of rust-lang#34938, to add a lint for unused macros.
    
    We now output warnings by default when we encounter a macro that we didn't use for expansion.
    
    Issues to be resolved before this PR is ready for merge:
    
    - [x] fix the NodeId issue described above
    - [x] remove all unused macros from rustc and the libraries or set `#[allow(unused_macros)]` next to them if they should be kept for some reason. This is needed for successful boostrap and bors to accept the PR. -> rust-lang#41934
    - [x] ~~implement the full extent of rust-lang#34938, that means the macro match arm checking as well.~~ *let's not do this for now*
    Mark-Simulacrum authored May 16, 2017
    Configuration menu
    Copy the full SHA
    38bdfdc View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#41932 - wesleywiser:py-to-rust, r=alexcrichton

    Rewrite make-win-dist.py in Rust
    
    Fixes rust-lang#41568
    Mark-Simulacrum authored May 16, 2017
    Configuration menu
    Copy the full SHA
    0dc1d45 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#41982 - gamazeps:thread-yield-now, r=Guilla…

    …umeGomez
    
    [Doc] Explain why `thread::yield_now` could be used.
    
    Part of rust-lang#29378.
    
    r? @steveklabnik
    Mark-Simulacrum authored May 16, 2017
    Configuration menu
    Copy the full SHA
    e4a4f53 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#41994 - gamazeps:thread-builder, r=Guillaum…

    …eGomez
    
    [Doc] Implrove `thread::Builder`'s doc.
    
    Part of rust-lang#29378 .
    
    - Explains *why* we would use the builder instead ofthe free function.
    - Changes the parent-child explanation for a spawned-caller in `thread::Builder::spawn`
    - Adds a link to `io::Result` in `thread::Builder`
    - Corrects the return type doc in `thread::Builder::spawn`
    
    r? @rust-lang/docs
    Mark-Simulacrum authored May 16, 2017
    Configuration menu
    Copy the full SHA
    b5a24d4 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#41995 - gamazeps:thread-localkey, r=frewsxcv

    [Doc] Add links to the `thread::LocalKey` doc.
    
    Part of rust-lang#29378 .
    
    I do not know exactly what should be done for the `cleanup` part, if you have any idea I'll gladly do it.
    
    r? @rust-lang/docs
    Mark-Simulacrum authored May 16, 2017
    Configuration menu
    Copy the full SHA
    4e48bfb View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#42001 - ollie27:rustdoc_extern_fn, r=Guilla…

    …umeGomez
    
    rustdoc: Display `extern "C" fn` instead of `extern fn`
    
    It was decided in rust-lang/style-team#52 to be explicit about the ABI so rustdoc should follow suit.
    Mark-Simulacrum authored May 16, 2017
    Configuration menu
    Copy the full SHA
    bf3abe0 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#42005 - jseyfried:fix_macro_regression, r=nrc

    Fix regression in `macro_rules!` name matching
    
    Fixes rust-lang#41803.
    r? @nrc
    Mark-Simulacrum authored May 16, 2017
    Configuration menu
    Copy the full SHA
    747f7d2 View commit details
    Browse the repository at this point in the history