-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite make-win-dist.py in Rust #41568
Comments
I'd like to take this, if that's ok. |
@wesleywiser sure thing! Let me know if you need any assistance |
@alexcrichton How should I test my change? I tried running
and I'm not sure how to install |
@wesleywiser You'd follow the instructions in the readme to install msys2 and use that to acquire MinGW. https://github.com/rust-lang/rust/blob/master/README.md#mingw |
@wesleywiser my recommendation would probably be to just run it directly in the sense that I'd run the old script and then the new script. If the outputs are the same then we should be good to go! |
@alexcrichton , Are there other scripts need to be rewritten? I am glad to contribute too. |
@F001 if you're super ambitious there's also If you're interested in tackling that one I could make a tracking issue separately to follow that if you'd like! |
@alexcrichton , it sounds great! I'm excited to tackle this one. |
@F001 awesome! I've opened an issue to help track that script. |
Rewrite make-win-dist.py in Rust Fixes rust-lang#41568
Rewrite make-win-dist.py in Rust Fixes rust-lang#41568
Rewrite make-win-dist.py in Rust Fixes #41568
We've got a now-ancient Python script in the repository which has historically served the purpose of assembling the components of the rust-mingw package that we produce. Historically this was invoked from
make
, and implementing that script inmake
would be a nightmare!Nowadays we've got rustbuild, a build system in Rust, so let's keep leveraging it! This script is called from one location and should be relatively easy rewrite it directly inline. The Rust standard library should have all the tools needed to implement this script.
I'm tagging this as E-easy and E-mentor, please reach out to me if you'd like to take this on and need assistance!
The text was updated successfully, but these errors were encountered: