rustdoc: HTML-escape Rust code (from constants) #33372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially in cases like the one in the test file, this can blow up the docs big time if string constants in the code contain HTML. But also other constants can contain special chars (e.g. `&` as an operator in constant expressions).
|
r? @cmr (rust_highfive has picked a reviewer for you, use r? to override) |
|
Eek, that's concerning. Rustdoc really shouldn't have injection attacks! |
|
@bors r+ |
|
📌 Commit 1bcf41e has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 3, 2016
rustdoc: HTML-escape Rust code (from constants) Especially in cases like the one in the test file, this can blow up the rendering big time if string constants in the code contain HTML. But also other constants can contain special chars (e.g. `&` as an operator in constant expressions).
bors
added a commit
that referenced
this pull request
May 3, 2016
bors
added a commit
that referenced
this pull request
May 3, 2016
bors
added a commit
that referenced
this pull request
May 4, 2016
bors
added a commit
that referenced
this pull request
May 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially in cases like the one in the test file, this can blow up the rendering big time if string constants in the code contain HTML.
But also other constants can contain special chars (e.g.
&as an operator in constant expressions).