-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/book/getting-started.md: Spelling correction and revised wording. #33322
Conversation
…cutable from 'Converting to Cargo'.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for your work! Please squash your commits. |
In this case, I think it's okay to leave them unsquashed: they are two logical changes, even though they are both small. Thanks so much! @bors: r+ rollup |
📌 Commit 018c595 has been approved by |
doc/book/getting-started.md: Spelling correction and revised wording. The word 'Internet' was spelt with both an uppercase and a lowercase 'I'. The correct spelling seems to be a matter of some debate these days, however the first occurrence in the file has an uppercase 'I', so I've changed the second occurrence to suit for consistency. Under the section titled 'Converting to Cargo', there's mention of creating a new executable. This, however, is not part of the process described. I've revised the wording to reflect as much. Small changes, but I hope they are of benefit! :-) r? @steveklabnik
You're most welcome! I came across the rewrite of "The Book" (https://github.com/rust-lang/book) after submitting this PR. These issues exist there, too. Should I submit another PR to update the rewrite? |
Yes please! That'd be great :) |
Will do! :-) |
doc/book/getting-started.md: Spelling correction and revised wording. The word 'Internet' was spelt with both an uppercase and a lowercase 'I'. The correct spelling seems to be a matter of some debate these days, however the first occurrence in the file has an uppercase 'I', so I've changed the second occurrence to suit for consistency. Under the section titled 'Converting to Cargo', there's mention of creating a new executable. This, however, is not part of the process described. I've revised the wording to reflect as much. Small changes, but I hope they are of benefit! :-) r? @steveklabnik
The word 'Internet' was spelt with both an uppercase and a lowercase 'I'. The correct spelling seems to be a matter of some debate these days, however the first occurrence in the file has an uppercase 'I', so I've changed the second occurrence to suit for consistency.
Under the section titled 'Converting to Cargo', there's mention of creating a new executable. This, however, is not part of the process described. I've revised the wording to reflect as much.
Small changes, but I hope they are of benefit! :-)
r? @steveklabnik