Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Only record the same impl once #33153

Merged
merged 1 commit into from
Apr 24, 2016
Merged

Conversation

mitaa
Copy link
Contributor

@mitaa mitaa commented Apr 22, 2016

Due to inlining it is possible to visit the same module multiple times during <Cache as DocFolder>::fold_crate, so we keep track of the modules we've already visited.

fixes #33054

r? @alexcrichton

Due to inlining it is possible to visit the same module multiple times
during `<Cache as DocFolder>::fold_crate`, so we keep track of the
modules we've already visited.
@alexcrichton
Copy link
Member

@bors: r+ 8ab2c20

Thanks!

@bors
Copy link
Contributor

bors commented Apr 24, 2016

⌛ Testing commit 8ab2c20 with merge 8d0dd78...

bors added a commit that referenced this pull request Apr 24, 2016
rustdoc: Only record the same impl once

Due to inlining it is possible to visit the same module multiple times during `<Cache as DocFolder>::fold_crate`, so we keep track of the modules we've already visited.

fixes #33054

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Apr 24, 2016

💔 Test failed - auto-win-msvc-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Saturday, April 23, 2016, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-32-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-32-opt/builds/3136


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#33153 (comment)

@bors bors merged commit 8ab2c20 into rust-lang:master Apr 24, 2016
@mitaa mitaa deleted the rdoc-dejavu branch April 24, 2016 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate impl blocks in rustdoc
3 participants