Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate impl blocks in rustdoc #33054

Closed
caipre opened this issue Apr 17, 2016 · 1 comment · Fixed by #33153
Closed

Duplicate impl blocks in rustdoc #33054

caipre opened this issue Apr 17, 2016 · 1 comment · Fixed by #33153
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@caipre
Copy link
Contributor

caipre commented Apr 17, 2016

The inherent methods for structs in std::os::unix::net are shown twice, eg: http://doc.rust-lang.org/nightly/std/os/unix/net/struct.SocketAddr.html

Not sure whether this is limited to nightly or not.

Possibly related to #21474.
@GuillaumeGomez
Copy link
Member

It's "supposed" to have been fixed in this commit.

cc @alexcrichton

@alexcrichton alexcrichton added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 18, 2016
@mitaa mitaa mentioned this issue Apr 22, 2016
Merged
bors added a commit that referenced this issue Apr 24, 2016
@bors
Auto merge of #33153 - mitaa:rdoc-dejavu, r=alexcrichton
8d0dd78 
rustdoc: Only record the same impl once

Due to inlining it is possible to visit the same module multiple times during `<Cache as DocFolder>::fold_crate`, so we keep track of the modules we've already visited.

fixes #33054

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Only record the same impl once mitaa/rust
3 participants
@alexcrichton @caipre @GuillaumeGomez