Rollup of 10 pull requests #30445
Merged
Rollup of 10 pull requests #30445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Dec 17, 2015
steveklabnik
commented
- Successful merges: fix copy-paste typo in docs for wrapping_shr #30370, Used bold and italic in the markdown to make the stack and heap docum… #30404, Remove incorrect words about libcore's stability #30415, Remove rogue I #30419, small fix to str doc example #30428, doc: improve clarity by introducing a pause #30437, Change "big ask" to "tall order" in Rustonomicon. #30439, doc: add a missing comma #30441, doc: fix typo #30442, doc: no need to duplicate docs on renamed API #30443
- Failed merges:
The Rustonomicon's Lifetimes chapter uses the idiom "big ask", which is obscure compared to "tall order" (check Google ngrams). Also, it's easily mistaken for a typo; either "a big task" or "a big thing to ask" could plausibly work there.
…abnik …entation clearer I could not use colors as suggested for rust-lang#29854 because Github doesn't support these in markdown, however this solution may be better for color-blind readers.
…ote, r=alexcrichton
The comma removes the sorface ambiguity
…r=steveklabnik The Rustonomicon's Lifetimes chapter uses the idiom "big ask", which is obscure compared to "tall order" (check [Google ngrams](https://books.google.com/ngrams/graph?content=big+ask%2C+tall+order&year_start=1800)). Also, it's easily mistaken for a typo; either "a big task" or "a big thing to ask" could plausibly work there. r? @steveklabnik
|
@bors: r+ p=1 |
|
📌 Commit 7ad8fb9 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.