-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor error handling #30384
Refactor error handling #30384
Conversation
Travis is still unhappy but I can't quite see why. Still, this looks fine -- mostly just shuffling things around, from what I can tell. r=me once travis errors are resolved. I feel like the layering of emitters/handlers/etc always feels more complex (or maybe just less clear) than it seems like it needs to be, but that's certainly pre-existing. |
The idea (aiui) is that to implement a new way of dealing with errors, you just have to implement |
📌 Commit 0f1ae7b has been approved by |
📌 Commit 0f1ae7b has been approved by |
☔ The latest upstream changes (presumably #30206) made this pull request unmergeable. Please resolve the merge conflicts. |
Also split out emitters into their own module.
The intention here is that Session is a very thin wrapper over the error handling infra.
📌 Commit ff0c74f has been approved by |
Should make it possible to add JSON or HTML errors. Also tidies up a lot.
Should make it possible to add JSON or HTML errors. Also tidies up a lot.