fix the error span when accessing tuple/struct fields in a constant #30286
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
oli-obk
force-pushed
the
const_error_span
branch
from
5574b92 to
8867593
Compare
|
@bors r+ |
|
📌 Commit 8867593 has been approved by |
|
@bors r+ |
|
📌 Commit 8867593 has been approved by |
|
(sorry for closing, clicked wrong button) |
|
⌛ Testing commit 8867593 with merge 5907957... |
…sakis previously the error was erased and a `non-const path` error was emitted at the location of the field access instead of at the overflow location (as can be seen in the playground: http://is.gd/EuAF5F )
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 8867593 with merge ff140df... |
|
⛄ The build was interrupted to prioritize another pull request. |
previously the error was erased and a `non-const path` error was emitted at the location of the field access instead of at the overflow location (as can be seen in the playground: http://is.gd/EuAF5F )
previously the error was erased and a
non-const patherror was emitted at the location of the field access instead of at the overflow location (as can be seen in the playground: http://is.gd/EuAF5F )