Fixed remaining #Failure in docs to #Panics #18983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. |
|
Fix #18677 |
|
I don't think this quite covers all of #18677, or have you verified that this is the last remaining instance? Regardless though thanks! |
| @@ -839,7 +839,7 @@ pub fn short_usage(program_name: &str, opts: &[OptGroup]) -> String { | |||
| /// Note: Function was moved here from `std::str` because this module is the only place that | |||
| /// uses it, and because it was too specific for a general string function. | |||
| /// | |||
| /// #Failure: | |||
| /// #Panics: | |||
| /// | |||
| /// Fails during iteration if the string contains a non-whitespace | |||
There was a problem hiding this comment.
You may want to rename "Fails" here to "Panics" as well.
|
This needs rebased, and @alexcrichton 's comment addressed, @sheroze1123 😄 |
|
Closing due to inactivity, but feel free to reopen with a rebase and comments addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.