debuginfo: Activate LLDB tests on Darwin. #18092
Conversation
|
Awesome work @michaelwoerister! |
|
Whoops, it seems that I have broken GDB tests depending on breakpoints at specific line numbers. I'll fix them when I get to a computer... On October 16, 2014 5:31:41 PM CEST, Alex Crichton [email protected] wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
michaelwoerister
force-pushed
the
lldb-test-versioning
branch
2 times, most recently
from
b86325c to
def11e0
Compare
|
The tests should be fixed now. |
…ute to help the build bots.
…ed version has no problems with that.
michaelwoerister
force-pushed
the
lldb-test-versioning
branch
from
7cc2115 to
8370321
Compare
michaelwoerister
force-pushed
the
lldb-test-versioning
branch
from
8370321 to
423dca7
Compare
|
I'm not sure what went wrong the last time. It said that it couldn't create the debugger 'target', meaning that it probably didn't find the executable to debug (or couldn't access it because of access rights or code signing issues). Interestingly it worked on the try branch just now, without any change. Both times it ran on bot I've added some more output to the LLDB script, so if it fails again, I should hopefully be able to find out what the actual problem was. |
…alexcrichton Now that there are build bots with a stable enough LLDB version on OSX we can finally let the tests run on every PR! :joy_cat:
…alexcrichton Now that there are build bots with a stable enough LLDB version on OSX we can finally let the tests run on every PR! :joy_cat:
|
Alright! So the tests were actually executed two times, once on mac5 and once on mac6. On mac4 they have been ignored as they should be. |
|
I think that we're guaranteed at least for now that at least one build will run on mac5 or mac6 (b/c mac4 can't run all the builds at once), so we should be somewhat ok on that front (hopefully not too bad!). Awesome work @michaelwoerister, so glad to see these tests checked in! |
fix: Correctly escape strings in our quote macro This is a small change, but it was the cause of 90% of the errors in `rust-analyzer diagnostics .` 🫢 (because this worked incorrectly with `stringify!()`, which means every `quote!()` (the original one) quoting a string also didn't work). With this change and rust-lang#18085 together, all remaining errors are type errors. This may mean we can enable more errors, but this is out of scope for this PR.
Now that there are build bots with a stable enough LLDB version on OSX we can finally let the tests run on every PR!
😹