libgetopts: tweak HasHarg/Occur docs #16252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Optional, | ||
| /// The option occurs once or multiple times. | ||
| /// The option occurs zero or more times. |
There was a problem hiding this comment.
Should this be one or more?
There was a problem hiding this comment.
I think it shouldn't. That's partly why I'm making this PR. With Occur set to Multi, it is allowed for the option not to show up at all. With this PR, I'm assuming that the code is correct but the docs a little outdated.
|
Ok, thanks! Could you squash the commits together as well? |
|
Done. |
bors
added a commit
that referenced
this pull request
Aug 6, 2014
I found the current docs to be a little confusing. I believe this makes them straight to the point and less confusing.
This was referenced Oct 22, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
internal: Switch to `expected.assert_eq` for `ide` tests This PR switches from `assert_debug_eq` to `assert_eq` and only compares parts of the result and not the whole. The aim is to only compare parts which are relevant to the test and also make it more readable. Part of rust-lang#14268. ## Questions - [x] Can I use `Vec`? If not, what is the alternative? I assume I cannot because of: https://github.com/rust-lang/rust-analyzer/blob/c3a00b5468576de4e39adc8fa5ceae35a0024e49/docs/dev/architecture.md?plain=1#L413 - [x] Should I group it by file, as proposed by Lukas? ``` file_id 1: source_file_edits: - Indel { insert: "foo2", delete: 4..7 } file_id 2: file_system_edits: MoveFile AnchoredPathBuf { anchor: FileId(2), path: "foo2.rs", } ``` - [x] Is it okay to ignore `CreateFile` events? They do not have a FileId, which would be problematic, but they do not occur in the existing tests, so I marked them as `unreachable!()` so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the current docs to be a little confusing. I believe this makes them straight to the point and less confusing.