Rollup of 6 pull requests #136728

matthiaskrgr · 2025-02-08T02:58:50Z

Successful merges:

Debuginfo for function ZSTs should have alignment of 8 bits, not 1 bit #136640 (Debuginfo for function ZSTs should have alignment of 8 bits, not 1 bit)
Add a missing //@ needs-symlink to tests/run-make/libs-through-symlinks #136648 (Add a missing //@ needs-symlink to tests/run-make/libs-through-symlinks)
Label mismatched parameters at the def site for foreign functions #136651 (Label mismatched parameters at the def site for foreign functions)
Remove Linkage::Private and Linkage::Appending #136691 (Remove Linkage::Private and Linkage::Appending)
add module level doc for bootstrap:utils:exec #136692 (add module level doc for bootstrap:utils:exec)
i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4 #136700 (i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4)

r? @ghost
@rustbot modify labels: rollup

This is the same as Linkage::Internal except that it doesn't emit any symbol. Some backends may not support it and it isn't all that useful anyway.

It can only be used for certain LLVM internal variables like llvm.global_ctors which users are not allowed to define.

…ompiler-errors Debuginfo for function ZSTs should have alignment of 8 bits, not 1 bit In rust-lang#116096, function ZSTs were made to have debuginfo that gives them an alignment of “1”. But because alignment in LLVM debuginfo is denoted in *bits*, not bytes, this resulted in an alignment specification of 1 bit instead of 1 byte. I don't know whether this has any practical consequences, but I noticed that a test started failing when I accidentally fixed the mistake while working on rust-lang#136632, so I extracted the fix (and the test adjustment) to this PR.

…wesleywiser Add a missing `//@ needs-symlink` to `tests/run-make/libs-through-symlinks` r? ``@wesleywiser`` (since you [found it](https://rust-lang.zulipchat.com/#narrow/channel/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202025-02-06/near/498173394) :P or reroll)

Label mismatched parameters at the def site for foreign functions Nice and simple. Adds parameter marking for the only missing definition type. r? ``@compiler-errors``

Remove Linkage::Private and Linkage::Appending Neither of them has any use case. Neither known nor theoretical.

…s-for-bootstrap-utils-exec, r=onur-ozkan add module level doc for bootstrap:utils:exec This PR adds module level doc for bootstrap utils/exec module

i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4 See rust-lang#136495 for context. ``@sthibaul`` (the only listed target maintainer) said they would be [fine](rust-lang#136495 (comment)) with this change.

matthiaskrgr · 2025-02-08T02:59:53Z

@bors r+ rollup=never p=1

bors · 2025-02-08T02:59:56Z

📌 Commit a5b9e8c has been approved by matthiaskrgr

It is now in the queue for this repository.

matthiaskrgr · 2025-02-08T07:20:09Z

@bors p=6

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#136640 (Debuginfo for function ZSTs should have alignment of 8 bits, not 1 bit) - rust-lang#136648 (Add a missing `//@ needs-symlink` to `tests/run-make/libs-through-symlinks`) - rust-lang#136651 (Label mismatched parameters at the def site for foreign functions) - rust-lang#136691 (Remove Linkage::Private and Linkage::Appending) - rust-lang#136692 (add module level doc for bootstrap:utils:exec) - rust-lang#136700 (i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-02-08T08:31:13Z

⌛ Testing commit a5b9e8c with merge f580921...

bors · 2025-02-08T11:20:58Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing f580921 to master...

bors · 2025-02-08T11:21:57Z

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

matthiaskrgr · 2025-02-08T11:22:46Z

@bors retry

rust-timer · 2025-02-08T12:39:50Z

Finished benchmarking commit (f580921): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Max RSS (memory usage)

Results (secondary -2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.9%, secondary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[1.5%, 2.3%]	4
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-2.8%	[-3.6%, -2.1%]	2
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Binary size

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	5

Bootstrap: 778.886s -> 779.003s (0.02%)
Artifact size: 329.10 MiB -> 329.08 MiB (-0.01%)

bors · 2025-02-08T12:58:03Z

⌛ Testing commit a5b9e8c with merge 8ad2c97...

bors · 2025-02-08T15:47:03Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 8ad2c97 to master...

rust-timer · 2025-02-08T15:48:50Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#136640	Debuginfo for function ZSTs should have alignment of 8 bits…	`1aa98a5399f240ccf6c4a56868b95f88d5dd7d27` (link)
#136648	Add a missing `//@ needs-symlink` to `tests/run-make/libs-t…	`8c787f23bc28f66d073a185156c1f2f695a2e66f` (link)
#136651	Label mismatched parameters at the def site for foreign fun…	`00b6d0bf0b98fe16b9f14fafd312bac48266d7ee` (link)
#136691	Remove Linkage::Private and Linkage::Appending	`a8d29ef8ebf89cb898e81a5a4c9f902d51d40fb9` (link)
#136692	add module level doc for bootstrap:utils:exec	`1e667cf1332eb2705f72bf6100810bbfef39ae8a` (link)
#136700	i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4	`f63f934e3a677215bc1120e173de513b409530f6` (link)

previous master: d2f335d58e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-02-08T17:08:54Z

Finished benchmarking commit (8ad2c97): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[3.4%, 3.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.4%	[3.4%, 3.4%]	1

Cycles

Results (secondary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.5%, -2.0%]	3
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	5

Bootstrap: 781.002s -> 780.482s (-0.07%)
Artifact size: 329.08 MiB -> 329.09 MiB (0.00%)

Zalathar and others added 13 commits February 6, 2025 23:01

Debuginfo for function ZSTs should have alignment of 8 bits, not 1 bit

4385a9e

tests: add a missing needs-symlink

4f35eb3

Label mismatched parameters at the def site for foreign functions.

2dd6dc1

add module level doc for bootstrap:util:exec

08362f0

Remove Linkage::Private

382e403

This is the same as Linkage::Internal except that it doesn't emit any symbol. Some backends may not support it and it isn't all that useful anyway.

Remove Linkage::Appending

f68cd90

It can only be used for certain LLVM internal variables like llvm.global_ctors which users are not allowed to define.

i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4

69c4bcf

Rollup merge of rust-lang#136651 - Jarcho:fn_ctxt3, r=compiler-errors

50f9bba

Label mismatched parameters at the def site for foreign functions Nice and simple. Adds parameter marking for the only missing definition type. r? ``@compiler-errors``

Rollup merge of rust-lang#136691 - bjorn3:linkage_cleanup, r=jieyouxu

c9771e9

Remove Linkage::Private and Linkage::Appending Neither of them has any use case. Neither known nor theoretical.

Rollup merge of rust-lang#136692 - Shourya742:2025-02-07-add-rust-doc…

68ef129

…s-for-bootstrap-utils-exec, r=onur-ozkan add module level doc for bootstrap:utils:exec This PR adds module level doc for bootstrap utils/exec module

Rollup merge of rust-lang#136700 - RalfJung:hurd, r=Noratrieb

a5b9e8c

i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4 See rust-lang#136495 for context. ``@sthibaul`` (the only listed target maintainer) said they would be [fine](rust-lang#136495 (comment)) with this change.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 8, 2025

matthiaskrgr closed this Feb 8, 2025

matthiaskrgr reopened this Feb 8, 2025

bors merged commit 8ad2c97 into rust-lang:master Feb 8, 2025
13 checks passed

rustbot added this to the 1.86.0 milestone Feb 8, 2025

This was referenced Feb 8, 2025

setup typos check in CI #134006

Open

cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 2) #136632

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #136728

Rollup of 6 pull requests #136728

matthiaskrgr commented Feb 8, 2025

matthiaskrgr commented Feb 8, 2025

bors commented Feb 8, 2025

matthiaskrgr commented Feb 8, 2025

bors commented Feb 8, 2025

bors commented Feb 8, 2025

bors commented Feb 8, 2025

matthiaskrgr commented Feb 8, 2025

rust-timer commented Feb 8, 2025

bors commented Feb 8, 2025

bors commented Feb 8, 2025

rust-timer commented Feb 8, 2025

rust-timer commented Feb 8, 2025

Rollup of 6 pull requests #136728

Rollup of 6 pull requests #136728

Conversation

matthiaskrgr commented Feb 8, 2025

matthiaskrgr commented Feb 8, 2025

bors commented Feb 8, 2025

matthiaskrgr commented Feb 8, 2025

bors commented Feb 8, 2025

bors commented Feb 8, 2025

bors commented Feb 8, 2025

matthiaskrgr commented Feb 8, 2025

rust-timer commented Feb 8, 2025

Overall result: ✅ improvements - no action needed

bors commented Feb 8, 2025

bors commented Feb 8, 2025

rust-timer commented Feb 8, 2025

rust-timer commented Feb 8, 2025

Overall result: ✅ improvements - no action needed