Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4 #136700

Merged
merged 1 commit into from
Feb 8, 2025
Merged

i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4 #136700

merged 1 commit into from
Feb 8, 2025

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Feb 7, 2025 •
edited
Loading

See #136495 for context. @sthibaul (the only listed target maintainer) said they would be fine with this change.

@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@RalfJung RalfJung mentioned this pull request Feb 7, 2025
Open
5 tasks
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 7, 2025

📌 Commit 69c4bcf has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2025
@Noratrieb Noratrieb added relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2025
@rustbot rustbot mentioned this pull request Feb 7, 2025
Open
3 tasks
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#136700 - RalfJung:hurd, r=Noratrieb
3d2d7d7 
i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4

See rust-lang#136495 for context. `@sthibaul` (the only listed target maintainer) said they would be [fine](rust-lang#136495 (comment)) with this change.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 7, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2025
@bors
Auto merge of rust-lang#136712 - matthiaskrgr:rollup-fd5sw3d, r=matth…
d032cf0 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#136640 (Debuginfo for function ZSTs should have alignment of 8 bits, not 1 bit)
 - rust-lang#136648 (Add a missing `//@ needs-symlink` to `tests/run-make/libs-through-symlinks`)
 - rust-lang#136651 (Label mismatched parameters at the def site for foreign functions)
 - rust-lang#136659 (Pick the max DWARF version when LTO'ing modules with different versions )
 - rust-lang#136691 (Remove Linkage::Private and Linkage::Appending)
 - rust-lang#136692 (add module level doc for bootstrap:utils:exec)
 - rust-lang#136700 (i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 8, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2025
@bors
Auto merge of rust-lang#136728 - matthiaskrgr:rollup-x2qh9yt, r=matth…
f580921 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#136640 (Debuginfo for function ZSTs should have alignment of 8 bits, not 1 bit)
 - rust-lang#136648 (Add a missing `//@ needs-symlink` to `tests/run-make/libs-through-symlinks`)
 - rust-lang#136651 (Label mismatched parameters at the def site for foreign functions)
 - rust-lang#136691 (Remove Linkage::Private and Linkage::Appending)
 - rust-lang#136692 (add module level doc for bootstrap:utils:exec)
 - rust-lang#136700 (i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4)

r? `@ghost`
`@rustbot` modify labels: rollup
@Noratrieb Noratrieb added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2025
@bors
Auto merge of rust-lang#136728 - matthiaskrgr:rollup-x2qh9yt, r=matth…
8ad2c97 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#136640 (Debuginfo for function ZSTs should have alignment of 8 bits, not 1 bit)
 - rust-lang#136648 (Add a missing `//@ needs-symlink` to `tests/run-make/libs-through-symlinks`)
 - rust-lang#136651 (Label mismatched parameters at the def site for foreign functions)
 - rust-lang#136691 (Remove Linkage::Private and Linkage::Appending)
 - rust-lang#136692 (add module level doc for bootstrap:utils:exec)
 - rust-lang#136700 (i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2025
@rust-timer
Unrolled build for rust-lang#136700
f63f934 
Rollup merge of rust-lang#136700 - RalfJung:hurd, r=Noratrieb

i686-unknown-hurd-gnu: bump baseline CPU to Pentium 4

See rust-lang#136495 for context. ``@sthibaul`` (the only listed target maintainer) said they would be [fine](rust-lang#136495 (comment)) with this change.
@bors bors merged commit a5b9e8c into rust-lang:master Feb 8, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 8, 2025
@RalfJung RalfJung deleted the hurd branch February 10, 2025 07:05
@jonathanpallant
Copy link
Contributor

Isn't this note now not relevant for this target?

[^x86_32-floats-x87]

@RalfJung
Copy link
Member Author

Ah right that should have been changed to x86_32-floats-return-ABI. I'll submit a follow-up PR.

@RalfJung RalfJung mentioned this pull request Feb 10, 2025
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 11, 2025
@jhpratt
Rollup merge of rust-lang#136830 - RalfJung:hurd-x87-footnote, r=Nora…
9c5831d 
…trieb

fix i686-unknown-hurd-gnu x87 footnote

I missed this in rust-lang#136700.

r? `@Noratrieb`
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 11, 2025
@jhpratt
Rollup merge of rust-lang#136830 - RalfJung:hurd-x87-footnote, r=Nora…
e68a865 
…trieb

fix i686-unknown-hurd-gnu x87 footnote

I missed this in rust-lang#136700.

r? ``@Noratrieb``
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2025
@rust-timer
Unrolled build for rust-lang#136830
9205369 
Rollup merge of rust-lang#136830 - RalfJung:hurd-x87-footnote, r=Noratrieb

fix i686-unknown-hurd-gnu x87 footnote

I missed this in rust-lang#136700.

r? ``@Noratrieb``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidtwco davidtwco

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @Noratrieb @bors @jonathanpallant @davidtwco