-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove more unused files and directories in free runners #136535
ci: remove more unused files and directories in free runners #136535
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
70ff14d
to
8c7d76c
Compare
@bors try |
…irs, r=<try> ci: remove more unused files and directories in free runners try-job: aarch64-gnu
☀️ Try build successful - checks-actions |
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should be more aggressive here. For example, I could imagine that instead of listing out various binaries in /usr/local/bin and such, we'd instead try to delete everything except exactly what we need. On Linux at least presumably that "set of needed things" can be quite small, perhaps even not coming from GitHub at all. (e.g., use a minimal ubuntu docker image's contents as the base)
IIUC, it should be possible to create a mount point at (say) /mnt for /, rm -rf /, then (roughly) cp /mnt/minimal-root-base / or so.
I'm fine with playing whack a mole too, but it seems like a long journey...
r=me with nit fixed or not
This comment has been minimized.
This comment has been minimized.
1b99813
to
51f28a6
Compare
51f28a6
to
0cb224d
Compare
0cb224d
to
7f38958
Compare
I like the approach of specifying what files are needed instead of the unnecessary ones, but instead of applying to the whole ubuntu image, I would apply it to single directories where useful. E.g. we could list the binaries we need from the In theory this can also be applied to packages. E.g. list the packages you need and delete the ones that don't depend on them 💡 I'll merge this PR as it is, but I'll definitely keep in mind this principle for the next ones :) |
@bors try |
That honestly might be a good approach to make GHA environmental changes less likely to influence build/test outcomes (e.g. accidentally relying on something from GHA env that can change between image updates) |
💔 Test failed - checks-actions |
weird github error @bors try |
…irs, r=<try> ci: remove more unused files and directories in free runners try-job: aarch64-gnu
☀️ Try build successful - checks-actions |
@bors try |
…irs, r=<try> ci: remove more unused files and directories in free runners try-job: aarch64-gnu try-job: aarch64-gnu-debug
☀️ Try build successful - checks-actions |
@bors r=Mark-Simulacrum rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (cfe9ffc): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 788.14s -> 788.303s (0.02%) |
Before
From the

mingw-check
job in another PR:After
From the

mingw-check
job in this PR:try-job: aarch64-gnu
try-job: aarch64-gnu-debug