Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move x86_64-gnu-debug job to the free runner #136970

Merged
merged 1 commit into from
Feb 14, 2025
Merged

ci: move x86_64-gnu-debug job to the free runner #136970

merged 1 commit into from
Feb 14, 2025
+1 −3

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Feb 13, 2025 •
edited
Loading

After #136535 we don't need the large runner with more disk space anymore for this job, so we use the free runner instead.

try-job: x86_64-gnu-debug

@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 13, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2025
@bors
Auto merge of rust-lang#136970 - marcoieni:no-largedisk, r=<try>
4b326c1 
ci: move jobs using the largedisk runner to the free runner

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
try-job: dist-powerpc64le-linux
try-job: x86_64-gnu-debug
@bors
Copy link
Contributor

bors commented Feb 13, 2025

⌛ Trying commit 392328b with merge 4b326c1...

@marcoieni
Copy link
Member Author

marcoieni commented Feb 13, 2025 •
edited
Loading

Actually I think I made a mistake, probably this isn't going to work 😅
I will cancel the bors workflow from the UI

@marcoieni marcoieni marked this pull request as draft February 13, 2025 10:24
@bors
Copy link
Contributor

bors commented Feb 13, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2025
@marcoieni marcoieni changed the title ci: move jobs using the largedisk runner to the free runner ci: move x86_64-gnu-debug job to the free runner Feb 13, 2025
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Feb 13, 2025

⌛ Trying commit 8ff3639 with merge a5ecda1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2025
@bors
Auto merge of rust-lang#136970 - marcoieni:no-largedisk, r=<try>
a5ecda1 
ci: move `x86_64-gnu-debug` job to the free runner

try-job: x86_64-gnu-debug
@bors
Copy link
Contributor

bors commented Feb 13, 2025

☀️ Try build successful - checks-actions
Build commit: a5ecda1 (a5ecda1eb05091d4535c4df4e30b0a9c2a52cd15)

@marcoieni
Copy link
Member Author

There's still 52GB of available space, at the end of the job 👍
image

@marcoieni marcoieni marked this pull request as ready for review February 13, 2025 13:48
@marcoieni
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2025
@marcoieni
Copy link
Member Author

marcoieni commented Feb 13, 2025 •
edited
Loading

Since this PR affects only one job that we tested in the try build, imo we can rollup this 🤔
But I'll leave it to the reviewer to choose 👍

@Kobzol
Copy link
Contributor

Kobzol commented Feb 13, 2025

Hmm, isn't it a bit suspicious that 50 GiB is now available when that job was previously on the verge of like 1-2 GiB left? 😅 But maybe I misremember.

@marcoieni
Copy link
Member Author

I also remember that. Maybe in the meantime something changed in the codebase.
You can check the latest auto build in rust-lang-ci — now this job is way more efficient:
image

@Kobzol
Copy link
Contributor

Kobzol commented Feb 13, 2025

Ok, let's see!

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Feb 13, 2025

📌 Commit 8ff3639 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 14, 2025
@workingjubilee
Rollup merge of rust-lang#136970 - marcoieni:no-largedisk, r=Kobzol
2aead2f 
ci: move `x86_64-gnu-debug` job to the free runner

try-job: x86_64-gnu-debug
This was referenced Feb 14, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
@bors
Auto merge of rust-lang#137001 - workingjubilee:rollup-u3dn4gc, r=wor…
6dfeab5 
…kingjubilee

Rollup of 11 pull requests

Successful merges:

 - rust-lang#136863 (rework rigid alias handling )
 - rust-lang#136869 (Fix diagnostic when using = instead of : in let binding)
 - rust-lang#136895 (debuginfo: Set bitwidth appropriately in enum variant tags)
 - rust-lang#136928 (eagerly prove WF when resolving fully qualified paths)
 - rust-lang#136941 (Move `llvm.ccache` to `build.ccache`)
 - rust-lang#136950 (rustdoc: use better, consistent SVG icons for scraped examples)
 - rust-lang#136957 (coverage: Eliminate more counters by giving them to unreachable nodes)
 - rust-lang#136960 (Compiletest should not inherit all host RUSTFLAGS)
 - rust-lang#136962 (unify LLVM version finding logic)
 - rust-lang#136970 (ci: move `x86_64-gnu-debug` job to the free runner)
 - rust-lang#136973 (Fix `x test --stage 1 ui-fulldeps` on macOS (until the next beta bump))

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0e56579 into rust-lang:master Feb 14, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 14, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
@rust-timer
Unrolled build for rust-lang#136970
19b4add 
Rollup merge of rust-lang#136970 - marcoieni:no-largedisk, r=Kobzol

ci: move `x86_64-gnu-debug` job to the free runner

try-job: x86_64-gnu-debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdno jdno

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@marcoieni @rustbot @bors @Kobzol @jdno