Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use free runners for x86_64-gnu-tools and x86_64-rust-for-linux #132396

Conversation

MarcoIeni
Copy link
Member

Similar to #132316

I noticed that some jobs running on large runners are significantly faster than the rest of the auto build.

Here's some data based on the latest 97 auto builds:

  • Average of these jobs:
    • x86_64-gnu-tools: 64 minutes
    • x86_64-rust-for-linux: 33 minutes
  • Minimum duration of the auto builds: 136 minutes (2h 16 min).
  • Average duration of the auto build: 155 minutes (2h 35 min).

In this PR I switch these jobs from large runners to free runners, to see if we can save some resources.

Imo if the try builds don't take longer than the average duration of the auto build we could merge this PR.

try-job: x86_64-gnu-tools
try-job: x86_64-rust-for-linux

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 31, 2024
@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
…6_64-gnu-tools-and-x86_64-rust-for-linux, r=<try>

CI: use free runners for x86_64-gnu-tools and x86_64-rust-for-linux

try-job: x86_64-gnu-tools
try-job: x86_64-rust-for-linux
@bors
Copy link
Contributor

bors commented Oct 31, 2024

⌛ Trying commit 3036f4f with merge 841116a...

@bors
Copy link
Contributor

bors commented Oct 31, 2024

☀️ Try build successful - checks-actions
Build commit: 841116a (841116af4787c4450c7a45bcac0dfeeb2ffeb50f)

@MarcoIeni MarcoIeni marked this pull request as ready for review October 31, 2024 11:24
@MarcoIeni
Copy link
Member Author

MarcoIeni commented Oct 31, 2024

@Kobzol looks great 🥳 Imo we can merge this 👍
Also, not sure why the free runner is faster than the large one, maybe some tests are skipped? Anyway, we'll keep the situation monitored in the auto builds of the next weeks 👍
image

@Kobzol
Copy link
Contributor

Kobzol commented Oct 31, 2024

I don't think there's any skipping in try builds here, definitely not in the RfL job, AFAIK. Anyway, it looks good, let's see what happens with CI times.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2024

📌 Commit 3036f4f has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#130693 (Add `minicore` test auxiliary and support `//@ add-core-stubs` directive in ui/assembly/codegen tests)
 - rust-lang#132316 (CI: use free runners for 3 fast windows jobs)
 - rust-lang#132354 (Add `lp64e` RISC-V ABI)
 - rust-lang#132395 (coverage: Avoid ICE when `coverage_cx` is unexpectedly unavailable)
 - rust-lang#132396 (CI: use free runners for x86_64-gnu-tools and x86_64-rust-for-linux)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c9584b7 into rust-lang:master Oct 31, 2024
7 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
Rollup merge of rust-lang#132396 - MarcoIeni:ci-use-free-runners-for-x86_64-gnu-tools-and-x86_64-rust-for-linux, r=Kobzol

CI: use free runners for x86_64-gnu-tools and x86_64-rust-for-linux

try-job: x86_64-gnu-tools
try-job: x86_64-rust-for-linux
@rustbot rustbot added this to the 1.84.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants