-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: use free runners for 3 fast windows jobs #132316
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
@bors try |
…=<try> CI: use free runners for 4 fast windows jobs I noticed those jobs are faster than the others. The longest is 1 h 30 min, while the [auto builds](https://github.com/rust-lang-ci/rust/actions?query=branch%3Aauto) usually take > 2h 20 min. I'll try how much time windows free runners take for these jobs to see if we can use them instead of the large one. Goal: these jobs shouldn't take longer than the slowest jobs of the auto build. - [ ] provide data based on multiple commits, not just based on one commit. try-job: dist-aarch64-msvc try-job: dist-i686-mingw try-job: dist-x86_64-mingw try-job: dist-x86_64-msvc-alt
I realized is also worth testing |
@MarcoIeni btw for whatever reason a few
I haven't bothered to check if the ones you're running here have such tests. EDIT: I messed up the order, it's actually |
Ok, thanks for looking into this! If I need to set that environment variable, how do I do it? By editing the workflow file maybe? |
I'm not sure if these specific set of (I mixed up, it should be unsetting that env var, not set) |
☀️ Try build successful - checks-actions |
@bors try |
This comment has been minimized.
This comment has been minimized.
…=<try> CI: use free runners for 4 fast windows jobs I noticed those jobs are faster than the others. The longest is 1 h 30 min, while the [auto builds](https://github.com/rust-lang-ci/rust/actions?query=branch%3Aauto) usually take > 2h 20 min. I'll try how much time windows free runners take for these jobs to see if we can use them instead of the large one. Goal: these jobs shouldn't take longer than the slowest jobs of the auto build. - [ ] provide data based on multiple commits, not just based on one commit. try-job: dist-i686-msvc try-job: dist-i686-mingw try-job: dist-x86_64-mingw try-job: dist-x86_64-msvc-alt
@Mark-Simulacrum I think we could merge this PR and monitor how these jobs perform in the auto builds in the next week. What do you think? |
I'm fine with that, r=me |
c3abc16
to
180d44e
Compare
180d44e
to
183599f
Compare
Force pushed, let me know if I need to do something else 👍 EDIT: Kobzol told me I can approve this with bors, I'll do it in the next comment. |
@bors r=Mark-Simulacrum |
… r=Mark-Simulacrum CI: use free runners for 3 fast windows jobs try-job: dist-i686-msvc try-job: dist-i686-mingw try-job: dist-x86_64-mingw try-job: dist-x86_64-msvc-alt
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#130693 (Add `minicore` test auxiliary and support `//@ add-core-stubs` directive in ui/assembly/codegen tests) - rust-lang#132316 (CI: use free runners for 3 fast windows jobs) - rust-lang#132354 (Add `lp64e` RISC-V ABI) - rust-lang#132395 (coverage: Avoid ICE when `coverage_cx` is unexpectedly unavailable) - rust-lang#132396 (CI: use free runners for x86_64-gnu-tools and x86_64-rust-for-linux) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#132316 - MarcoIeni:ci-free-runners-windows, r=Mark-Simulacrum CI: use free runners for 3 fast windows jobs try-job: dist-i686-msvc try-job: dist-i686-mingw try-job: dist-x86_64-mingw try-job: dist-x86_64-msvc-alt
I noticed that some windows jobs running on large runners are significantly faster than the rest of the auto build.
Here's some data based on the latest 97 auto builds:
dist-i686-mingw
: 88 minutesdist-x86_64-mingw
: 86 minutesdist-x86_64-msvc-alt
: 81 minutesIn this PR I switch these jobs from large runners to free runners, to see if we can save some resources.
Imo if the try builds don't take longer than the average duration of the auto build we could merge this PR.
try-job: dist-i686-msvc
try-job: dist-i686-mingw
try-job: dist-x86_64-mingw
try-job: dist-x86_64-msvc-alt