Refactoring to OpaqueTyOrigin
#131183
Merged
Refactoring to OpaqueTyOrigin
#131183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy HIR ty lowering was modified cc @fmease |
|
Hold up not ready yet @rustbot author |
rustbot
added
S-waiting-on-author
compiler-errors
force-pushed
the
opaque-ty-origin
branch
from
ecbd707
to
7cd466a
Compare
compiler-errors
commented
Oct 3, 2024
| @@ -105,7 +105,7 @@ fn future_trait_ref<'tcx>( | |||
| cx: &LateContext<'tcx>, | |||
| ty: &'tcx Ty<'tcx>, | |||
| ) -> Option<(&'tcx TraitRef<'tcx>, Vec<LifetimeName>)> { | |||
| if let TyKind::OpaqueDef(item_id, bounds, false) = ty.kind | |||
There was a problem hiding this comment.
This is the only change to semantics in clippy, but I don't think we need to explicitly opt out AFIT here.
There was a problem hiding this comment.
I don't think this is doing anything right now. We don't have tests for traits for this lint. I added one and changing false->_ in the current implementation doesn't change the behavior there. So removing this should be fine 👍
There was a problem hiding this comment.
Thank you for checking! ❤️
| @@ -636,8 +636,7 @@ impl<'tcx> EmbargoVisitor<'tcx> { | |||
| impl<'tcx> Visitor<'tcx> for EmbargoVisitor<'tcx> { | |||
| fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) { | |||
| if self.impl_trait_pass | |||
| && let hir::ItemKind::OpaqueTy(opaque) = item.kind | |||
| && !opaque.in_trait | |||
There was a problem hiding this comment.
I'm not sure why we were opting out in_trait from the embargo visitor, but I didn't see any change to behavior here.
|
ok, I think it's ready @rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 3, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131024 (Don't give method suggestions when method probe fails due to bad implementation of `Deref`) - rust-lang#131112 (TransmuteFrom: Gracefully handle unnormalized types and normalization errors) - rust-lang#131176 (.gitignore files for nix) - rust-lang#131183 (Refactoring to `OpaqueTyOrigin`) - rust-lang#131187 (Avoid ICE in coverage builds with bad `#[coverage(..)]` attributes) - rust-lang#131192 (Handle `rustc_query_impl` cases of `rustc::potential_query_instability` lint) - rust-lang#131197 (Avoid emptiness check in `PeekMut::pop`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2024
Rollup merge of rust-lang#131183 - compiler-errors:opaque-ty-origin, r=estebank Refactoring to `OpaqueTyOrigin` Pulled out of a larger PR that uses these changes to do cross-crate encoding of opaque origin, so we can use them for edition 2024 migrations. These changes should be self-explanatory on their own, tho 😄
|
bors wtf lol |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2024
…rrowck, r=<try> Try to point out when edition 2024 lifetime capture rules cause borrowck issues Lifetime capture rules in 2024 are modified to capture more lifetimes, which sometimes lead to some non-local borrowck errors. This PR attempts to link these back together with a useful note pointing out the capture rule changes. This is not a blocking concern, but I'd appreciate feedback (though, again, I'd like to stress that I don't want to block this PR on this): I'm worried about this note drowning in the sea of other diagnostics that borrowck emits. I was tempted to change the level of the note to `.span_warn` just so it would show up in a different color. Thoughts? Fixes rust-lang#130545 Opening as a draft first since it's stacked on rust-lang#131183. r? `@ghost`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 18, 2024
…r=estebank Refactoring to `OpaqueTyOrigin` Pulled out of a larger PR that uses these changes to do cross-crate encoding of opaque origin, so we can use them for edition 2024 migrations. These changes should be self-explanatory on their own, tho 😄
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2024
…rrowck, r=estebank Try to point out when edition 2024 lifetime capture rules cause borrowck issues Lifetime capture rules in 2024 are modified to capture more lifetimes, which sometimes lead to some non-local borrowck errors. This PR attempts to link these back together with a useful note pointing out the capture rule changes. This is not a blocking concern, but I'd appreciate feedback (though, again, I'd like to stress that I don't want to block this PR on this): I'm worried about this note drowning in the sea of other diagnostics that borrowck emits. I was tempted to change the level of the note to `.span_warn` just so it would show up in a different color. Thoughts? Fixes rust-lang#130545 Opening as a draft first since it's stacked on rust-lang#131183. r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2024
…rrowck, r=estebank Try to point out when edition 2024 lifetime capture rules cause borrowck issues Lifetime capture rules in 2024 are modified to capture more lifetimes, which sometimes lead to some non-local borrowck errors. This PR attempts to link these back together with a useful note pointing out the capture rule changes. This is not a blocking concern, but I'd appreciate feedback (though, again, I'd like to stress that I don't want to block this PR on this): I'm worried about this note drowning in the sea of other diagnostics that borrowck emits. I was tempted to change the level of the note to `.span_warn` just so it would show up in a different color. Thoughts? Fixes rust-lang#130545 Opening as a draft first since it's stacked on rust-lang#131183. r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of a larger PR that uses these changes to do cross-crate encoding of opaque origin, so we can use them for edition 2024 migrations. These changes should be self-explanatory on their own, tho 😄