Rollup of 5 pull requests

[matthiaskrgr]

Successful merges:

• Make casts of pointers to trait objects stricter #120248 (Make casts of pointers to trait objects stricter)
• Mark format! with must_use hint #127355 (Mark format! with must_use hint)
• Verify that allocations output by GVN are sufficiently aligned. #127399 (Verify that allocations output by GVN are sufficiently aligned.)
• clarify sys::unix::fd::FileDesc::drop comment #127460 (clarify sys::unix::fd::FileDesc::drop comment)
• bootstrap: once_cell::sync::Lazy -> std::sync::LazyLock #127467 (bootstrap: once_cell::sync::Lazy -> std::sync::LazyLock)

Failed merges:

• Remove StructuredDiag #127357 (Remove StructuredDiag)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=6

[bors]

📌 Commit a659f7a has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit a659f7a with merge a06e9c8...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a06e9c8 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#120248	Make casts of pointers to trait objects stricter	68e716ee1724c56f434d8948d6f3c0c594532cec (link)
#127355	Mark format! with must_use hint	05413a8a1c8704df349768ab3948dc5a9294ca15 (link)
#127399	Verify that allocations output by GVN are sufficiently alig…	5b9176f9cd315b66640bb79633cca3fec0218c8c (link)
#127460	clarify sys::unix::fd::FileDesc::drop comment	60c09aa7557ece95dad86d03ca8f3c8a186a575a (link)
#127467	bootstrap: once_cell::sync::Lazy -> std::sync::LazyLock	fdd928748e990ccd0d67b7fad4f548612248b91e (link)

previous master: cfd7cf5a0e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (a06e9c8): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.4%]	7
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.8%, 0.4%]	8

Max RSS (memory usage)

Results (primary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	5.1%	[2.5%, 10.5%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.8%	[-7.4%, -0.7%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[-7.4%, 10.5%]	9

Cycles

Results (primary -1.0%, secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[1.9%, 3.1%]	6
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Binary size

Results (primary -0.0%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	27
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	4
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.0%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.4%, 0.1%]	34

Bootstrap: 701.941s -> 700.067s (-0.27%)
Artifact size: 328.61 MiB -> 328.73 MiB (0.04%)

[Kobzol]

@rust-timer build 05413a8

[rust-timer]

Finished benchmarking commit (05413a8): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	8
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.7%, 0.5%]	9

Max RSS (memory usage)

Results (primary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	6.3%	[2.9%, 11.5%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.9%	[-6.8%, -4.4%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[-6.8%, 11.5%]	7

Cycles

Results (primary -0.9%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.2%, 2.8%]	3
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Binary size

Results (primary -0.0%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	27
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	4
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.1%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.4%, 0.1%]	33

Bootstrap: 701.941s -> 700.738s (-0.17%)
Artifact size: 328.61 MiB -> 328.73 MiB (0.04%)

[Kobzol]

Interesting, I did not expect #127355 to have any perf. effect. Maybe the macro change?