Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #127296

Merged
merged 17 commits into from
Jul 4, 2024
Merged

Rollup of 6 pull requests #127296

merged 17 commits into from
Jul 4, 2024

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    b1a0c0b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82b4af7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99365a5 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Configuration menu
    Copy the full SHA
    8127461 View commit details
    Browse the repository at this point in the history
  2. Update LLVM submodule

    DianQK committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    da81d0d View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    bd2ff51 View commit details
    Browse the repository at this point in the history
  2. Minor change

    bjorn3 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ec2d1b0 View commit details
    Browse the repository at this point in the history
  3. Inline Query::default()

    bjorn3 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f276459 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Configuration menu
    Copy the full SHA
    9f32459 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    403e2e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4930937 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#127092 - compiler-errors:rtn-dots-redux, r=…

    …estebank
    
    Change return-type-notation to use `(..)`
    
    Aligns the syntax with the current wording of [RFC 3654](rust-lang/rfcs#3654). Also implements rustfmt support (along with making a match exhaustive).
    
    Tracking:
    * rust-lang#109417
    matthiaskrgr authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    33e9f25 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#127184 - bjorn3:interface_refactor2, r=Nadr…

    …ieril
    
    More refactorings to rustc_interface
    
    Follow up to rust-lang#126834
    matthiaskrgr authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9f8cf64 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#127190 - DianQK:llvm-backport, r=nikic

    Update LLVM submodule
    
    Fixes rust-lang#112548 and unlock rust-lang#125642.
    
    r? ``@cuviper`` or ``@nikic``
    matthiaskrgr authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    77fa597 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#127253 - chenyukang:yukang-fix-126246-fn-pa…

    …rameters-check, r=estebank
    
    Fix incorrect suggestion for extra argument with a type error
    
    Fixes rust-lang#126246
    
    I tried to fix it in the `find_errors` of ArgMatrix, but seems it's hard to avoid breaking some other test cases.
    
    The root cause is we eliminate the first argument even with a type error at here:
    https://github.com/rust-lang/rust/blob/6292b2af620dbd771ebb687c3a93c69ba8f97268/compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs#L664
    
    So the left argument is always treated as extra one.
    
    But if there is already a type error, an error message will be generated firstly, which make this issue a trivial one.
    matthiaskrgr authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    6031309 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#127280 - ferrocene:hoverbear/disable-rmake-…

    …rustdoc-io-error, r=jieyouxu
    
    Disable rmake test rustdoc-io-error on riscv64gc-gnu
    
    In rust-lang#126917 we disabled `inaccessible-temp-dir` on `riscv64gc-gnu` because the container runs the build as `root` (just like the `armhf-gnu` builds). Tests creating an inaccessible test directory are not possible, since `root` can always touch those directories.
    
    https://github.com/rust-lang/rust/blob/553a69030e5a086eb3841d020db8c9c463948c72/src/ci/docker/host-x86_64/disabled/riscv64gc-gnu/Dockerfile#L99
    
    This means the tests are run as `root`. As `root`, it's perfectly normal and reasonable to violate permission checks this way:
    
    ```bash
    $ sudo mkdir scratch
    $ sudo chmod o-w scratch
    $ sudo mkdir scratch/backs
    $
    ```
    
    Because of this, this PR makes the test ignored on `riscv64gc` (just like on `armhf-gnu`) for now.
    
    As an alternative, I believe the best long-term strategy would be to not run the tests as `root` for this job. Some preliminary exploration was done in rust-lang#126917 (comment), however that appears a larger lift.
    
    ## Testing
    
    > [!NOTE]
    > `riscv64gc-unknown-linux-gnu` is a [**Tier 2 with Host Tools** platform](https://doc.rust-lang.org/beta/rustc/platform-support.html), all tests may not necessarily pass! This change should only ignore `inaccessible-temp-dir` and not affect other tests.
    
    You can test out the job locally:
    
    ```sh
    DEPLOY=1 ./src/ci/docker/run.sh riscv64gc-gnu
    ```
    
    r? `@jieyouxu`
    matthiaskrgr authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    00765e1 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#127294 - ldm0:ldm_coroutine2, r=lcnr

    Less magic number for corountine
    matthiaskrgr authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    79bdb89 View commit details
    Browse the repository at this point in the history