Fix try builds on the msvc builder #113226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The windows tarballs and installers expect clippy to be present, but it's not always the case. For example, in try builds.
The windows tarballs and installers expect rust-analyzer to be present, but it's not always the case. For example, in try builds.
rustbot
added
S-waiting-on-review
|
To provide more context for others: try builds are not actually normally executed on Part of the code already checked before if rust-analyzer is present, so this also seems like a bugfix (it checked at some places, but not all of them). I tested on #112235 that this does indeed fix msvc try builds. @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#113168 (fix(resolve): skip assertion judgment when NonModule is dummy) - rust-lang#113174 (Better messages for next on a iterator inside for loops) - rust-lang#113182 (Error when RPITITs' hidden types capture more lifetimes than their trait definitions) - rust-lang#113196 (Fix associated items effective visibility calculation for type privacy lints) - rust-lang#113226 (Fix try builds on the msvc builder) - rust-lang#113227 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try builds have been optimized to build less components, however bootstrap was still expecting them to be present on msvc. This PR (extracted from #112267) fixes that.
r? @Kobzol