Better messages for next on a iterator inside for loops #113174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
chenyukang
force-pushed
the
yukang-fix-102972-loop-next
branch
from
21de1bc
to
28310e6
Compare
chenyukang
force-pushed
the
yukang-fix-102972-loop-next
branch
from
28310e6
to
44a8a8d
Compare
compiler-errors
approved these changes
Jun 30, 2023
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 30, 2023
…next, r=compiler-errors Better messages for next on a iterator inside for loops Fixes rust-lang#102972
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Jul 1, 2023
…next, r=compiler-errors Better messages for next on a iterator inside for loops Fixes rust-lang#102972
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#113168 (fix(resolve): skip assertion judgment when NonModule is dummy) - rust-lang#113174 (Better messages for next on a iterator inside for loops) - rust-lang#113182 (Error when RPITITs' hidden types capture more lifetimes than their trait definitions) - rust-lang#113196 (Fix associated items effective visibility calculation for type privacy lints) - rust-lang#113226 (Fix try builds on the msvc builder) - rust-lang#113227 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup
estebank
added a commit
to estebank/rust
that referenced
this pull request
Jul 8, 2023
When encountering a for loop that is rejected by the borrow checker because it is being advanced within its body, provide a structured suggestion for `while let Some(pat) = iter.next()`.
estebank
added a commit
to estebank/rust
that referenced
this pull request
Oct 11, 2023
When encountering a for loop that is rejected by the borrow checker because it is being advanced within its body, provide a structured suggestion for `while let Some(pat) = iter.next()`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2023
Use structured suggestion for rust-lang#113174 When encountering a for loop that is rejected by the borrow checker because it is being advanced within its body, provide a structured suggestion for `while let Some(pat) = iter.next()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102972