-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update stdarch #105784
update stdarch #105784
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
cc @calebzulawski Any idea why this is failing? I would have thought your PR #103750 makes this work. |
It looks like std is built with the beta compiler, which doesn't have those changes yet |
The beta compiler should have been updated just last week though, so I would expect it to include these changes. |
The log shows downloading the beta compiler from Nov 1, that sounds like 1.66 rather than 1.67 |
Blocked on #105741. |
This comment has been minimized.
This comment has been minimized.
#105741 is now merged, can you rebase? |
This will allow using miri on simd instructions rust-lang/stdarch#1347 (comment)
a193bcb
to
a538723
Compare
This comment has been minimized.
This comment has been minimized.
@Amanieu Do you have an idea why it is failing? Can I help somehow? |
Those errors are due to changes from #100752. Some feature names have been deprecated in the |
Ah actually, as part of this update, this file needs to change too: rust/library/std/tests/run-time-detect.rs Line 123 in c757267
rust/library/std/tests/run-time-detect.rs Line 126 in c757267
rust/library/std/tests/run-time-detect.rs Line 132 in c757267
avx512gfni , avx512vaes , and avx512vpclmulqdq should all have the avx512 prefix removed.
|
@calebzulawski thanks for the help. The CI checks are passing now. |
@bors r+ |
update stdarch This will allow using miri on simd instructions rust-lang/stdarch#1347 (comment)
Rollup of 8 pull requests Successful merges: - rust-lang#105784 (update stdarch) - rust-lang#106856 (core: Support variety of atomic widths in width-agnostic functions) - rust-lang#107171 (rustc_metadata: Fix `encode_attrs`) - rust-lang#107242 (rustdoc: make item links consistently use `title="{shortty} {path}"`) - rust-lang#107279 (Use new solver during selection) - rust-lang#107284 (rustdoc: use smarter encoding for playground URL) - rust-lang#107325 (rustdoc: Stop using `HirId`s) - rust-lang#107336 (rustdoc: remove mostly-unused CSS classes `import-item` and `module-item`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
76: detect: Workaround Exynos 9810 bug on aarch64 Android r=taiki-e a=taiki-e Samsung Exynos 9810 has a bug that big and little cores have different ISAs. And on older Android (pre-9), the kernel incorrectly reports that features available only on some cores are available on all cores. See https://reviews.llvm.org/D114523 for details. Our own run-time detection code has not been released yet and is not a problem, but portable-atomic < 1.1 may have been affected by this issue since rustc 1.69-nightly when is_aarch64_feature_detected supported run-time detection on Android. (rust-lang/stdarch#1351, rust-lang/rust#105784) A patch on stdarch side: rust-lang/stdarch#1378 Co-authored-by: Taiki Endo <[email protected]>
This will allow using miri on simd instructions
rust-lang/stdarch#1347 (comment)