Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurately report error when formal and expected signature types differ #104261

Merged
merged 2 commits into from
Nov 12, 2022
Merged

More accurately report error when formal and expected signature types differ #104261

merged 2 commits into from
Nov 12, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #104242

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2022
@estebank
Copy link
Contributor

r? @estebank
@bors r+

@bors
Copy link
Contributor

bors commented Nov 11, 2022

📌 Commit 55f1f99 has been approved by estebank

It is now in the queue for this repository.

@rustbot rustbot assigned estebank and unassigned cjgillot Nov 11, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104261 - compiler-errors:formal-and-expecte…
c2389a1 
…d-differ, r=estebank

More accurately report error when formal and expected signature types differ

Fixes rust-lang#104242
This was referenced Nov 12, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2022
@bors
Auto merge of rust-lang#104325 - GuillaumeGomez:rollup-19bzwoa, r=Gui…
cd12888 
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104110 (prevent uninitialized access in black_box for zero-sized-types)
 - rust-lang#104117 (Mark `trait_upcasting` feature no longer incomplete.)
 - rust-lang#104144 (Suggest removing unnecessary `.` to use a floating point literal)
 - rust-lang#104250 (Migrate no result page link color to CSS variables)
 - rust-lang#104261 (More accurately report error when formal and expected signature types differ)
 - rust-lang#104263 (Add a reference to ilog2 in leading_zeros integer docs)
 - rust-lang#104308 (Remove the old `ValidAlign` name)
 - rust-lang#104319 (Fix non clickable source link)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fe80364 into rust-lang:master Nov 12, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 12, 2022
@compiler-errors compiler-errors deleted the formal-and-expected-differ branch August 11, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Confusing diagnostic when type mismatch on a tuple struct's generic type: Consider removing the ``
5 participants
@compiler-errors @rustbot @estebank @bors @cjgillot