-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #104246
Rollup of 9 pull requests #104246
Conversation
On arm, llvm treats the C calling convention as `aapcs` on soft-float targets and `aapcs-vfp` on hard-float targets [1]. UEFI specifies in the arm calling convention that floating point extensions aren't used [2], so always translate `efiapi` to `aapcs` on arm. [1]: rust-lang/compiler-builtins#116 (comment) [2]: https://uefi.org/specs/UEFI/2.10/02_Overview.html#detailed-calling-convention rust-lang#65815
…i-obk Add loongarch64 abi support
…wesleywiser Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor Most places that are constructing a `FulfillmentContext` should be constructing a `TraitEngine` generically, so later on if/when we're transitioning it'll be easier. Logical extension of rust-lang#99746
…rochenkov Suggest `is_some` when we've found `Option` but expected `bool` Thanks `@lunasorcery` for the suggestion.
…-dead Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher` This PR enables using Hashes in const context. r? ``@fee1-dead``
…r=nagisa Use aapcs for efiapi calling convention on arm On arm, [llvm treats the C calling convention as `aapcs` on soft-float targets and `aapcs-vfp` on hard-float targets](rust-lang/compiler-builtins#116 (comment)). UEFI specifies in the arm calling convention that [floating point extensions aren't used](https://uefi.org/specs/UEFI/2.10/02_Overview.html#detailed-calling-convention), so always translate `efiapi` to `aapcs` on arm. rust-lang#65815
…inding-issue, r=oli-obk Tighten the 'introduce new binding' suggestion Fixes rust-lang#104086
…ler-errors `EarlyBinder` docs
Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor` Fixes rust-lang#104209
…i-obk Use `const_error_with_guaranteed` more Better to pass down an ErrorGuaranteed rather than making a new one out of thin air, for some usages. Also for the ones where we *do* need to delay a bug, that delayed bug will have a more descriptive message.
@bors r+ p=5 rollup=never |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: 01a6f30324 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (a3c0a02): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Successful merges:
TraitEngine
in more places, restrict visibility ofFulfillmentCtxt
constructor #103863 (UseTraitEngine
in more places, restrict visibility ofFulfillmentCtxt
constructor)is_some
when we've foundOption
but expectedbool
#104036 (Suggestis_some
when we've foundOption
but expectedbool
)Hash
,Hasher
andBuildHasher
#[const_trait]
and makeSip
constHasher
#104060 (MakeHash
,Hasher
andBuildHasher
#[const_trait]
and makeSip
constHasher
)EarlyBinder
docs #104194 (EarlyBinder
docs)ConstKind::Error
inRequiredConstsVisitor
#104233 (Don't ICE when encounteringConstKind::Error
inRequiredConstsVisitor
)const_error_with_guaranteed
more #104235 (Useconst_error_with_guaranteed
more)Failed merges:
:target
rules to use CSS variables #104169 (Migrate:target
rules to use CSS variables)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup