fix almost_swapped: Ignore external macros
#10502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
blyxyas
changed the title
almost_swapped: Ignore external macros
|
As giraffate also managed #10499 |
giraffate
reviewed
Mar 16, 2023
giraffate
reviewed
Mar 16, 2023
blyxyas
force-pushed
the
fix-almost_swapped
branch
from
f15ce92 to
9546517
Compare
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Apr 22, 2023
Closed
soenkehahn
added a commit
to ordinals/ord
that referenced
this pull request
Apr 22, 2023
Should be reverted once rust-lang/rust-clippy#10502 is released in a stable `clippy`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10421 ; Related to #10499 (Fixing points 1 and 3 from #10421)
changelog: [
almost_swapped]: Add a check to ignore external macros