Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy #2035

Closed
casey opened this issue Apr 20, 2023 · 2 comments · Fixed by #2037
Closed

Fix clippy #2035

casey opened this issue Apr 20, 2023 · 2 comments · Fixed by #2037

Comments

@casey
Copy link
Collaborator

casey commented Apr 20, 2023

Clippy is currently failing, I think because of this: rust-lang/rust-clippy#10499

The failure is in clap, a dependency. I don't know how to suppress this error. Also, I think maybe it doesn't happen in clap 4.0, but we're blocked on upgrading to 4.0 on them supporting color in help text.

@soenkehahn
Copy link
Collaborator

Hmm, this is a gnarly issue. I don't understand why #![allow(clippy::correctness)] doesn't work. It does work when the same lint is triggered by hand-written code, but it doesn't seem to work for macro-generated code. 🤷

One option might be to switch clippy to nightly, since there these lints seem to be disabled for macros, I think through rust-lang/rust-clippy#10502.

@soenkehahn
Copy link
Collaborator

I put up a PR here: #2037. I'm not happy with that solution, but at least it's a working solution. Which I can't say of anything else I tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants