Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The use_self lint has too many bugs open - should be disabled by default #4859

Closed
gnzlbg opened this issue Nov 28, 2019 · 1 comment · Fixed by #4863
Closed

The use_self lint has too many bugs open - should be disabled by default #4859

gnzlbg opened this issue Nov 28, 2019 · 1 comment · Fixed by #4863
Assignees
@phansch
Labels
good-first-issue These issues are a good way to get started with Clippy

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 28, 2019

The use_self lint is useful, but it has so many bugs open that disabling it is a must.

It should IMO be disabled by default until most of the bugs with it are fixed.
@flip1995 flip1995 added the good-first-issue These issues are a good way to get started with Clippy label Nov 28, 2019
@flip1995
Copy link
Member

Agreed: #4734 #4305 #4143 #4140 #3909 #3881 #3859 #3410 #2843

@phansch phansch self-assigned this Nov 29, 2019
@phansch phansch mentioned this issue Nov 29, 2019
Merged
bors added a commit that referenced this issue Nov 29, 2019
@bors
Auto merge of #4863 - phansch:use_self, r=flip1995
5de93cc 
Move use_self to nursery

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
bors added a commit that referenced this issue Nov 29, 2019
@bors
Auto merge of #4863 - phansch:use_self, r=flip1995
0403687 
Move use_self to nursery

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
@bors bors closed this as completed in 70a2a29 Nov 29, 2019
@davidpdrsn davidpdrsn mentioned this issue Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phansch phansch

Labels
good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move use_self to nursery phansch/rust-clippy
3 participants
@gnzlbg @phansch @flip1995