Skip to content

Commit

Permalink
Auto merge of #4863 - phansch:use_self, r=flip1995
Browse files Browse the repository at this point in the history
Move use_self to nursery

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
  • Loading branch information
bors committed Nov 29, 2019
2 parents 350f3d6 + fd7eca2 commit 5de93cc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion clippy_lints/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1050,7 +1050,6 @@ pub fn register_plugins(store: &mut lint::LintStore, sess: &Session, conf: &Conf
LintId::of(&unicode::NON_ASCII_LITERAL),
LintId::of(&unicode::UNICODE_NOT_NFC),
LintId::of(&unused_self::UNUSED_SELF),
LintId::of(&use_self::USE_SELF),
]);

store.register_group(true, "clippy::internal", Some("clippy_internal"), vec![
Expand Down Expand Up @@ -1579,6 +1578,7 @@ pub fn register_plugins(store: &mut lint::LintStore, sess: &Session, conf: &Conf
LintId::of(&mutex_atomic::MUTEX_INTEGER),
LintId::of(&needless_borrow::NEEDLESS_BORROW),
LintId::of(&path_buf_push_overwrite::PATH_BUF_PUSH_OVERWRITE),
LintId::of(&use_self::USE_SELF),
]);
}

Expand Down
2 changes: 1 addition & 1 deletion clippy_lints/src/use_self.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ declare_clippy_lint! {
/// }
/// ```
pub USE_SELF,
pedantic,
nursery,
"Unnecessary structure name repetition whereas `Self` is applicable"
}

Expand Down
2 changes: 1 addition & 1 deletion src/lintlist/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2193,7 +2193,7 @@ pub const ALL_LINTS: [Lint; 338] = [
},
Lint {
name: "use_self",
group: "pedantic",
group: "nursery",
desc: "Unnecessary structure name repetition whereas `Self` is applicable",
deprecation: None,
module: "use_self",
Expand Down

0 comments on commit 5de93cc

Please sign in to comment.