Update which, quote and proc_macro.

[emilio]

Fixes #1407.

[emilio]

cc @Eijebong, last commit is a rebase of yours. If you could take a look it'd be great.

[ignatenkobrain]

One test failed due to missing conversion to #[doc

[ignatenkobrain]

Meh, it seems that this triggers rust-lang/cargo#2589.

See cbindgen's similar issues: mozilla/cbindgen#203

[ignatenkobrain]

it's enough to keep which on 1.x in order to avoid triggering that bug in cargo.

[emilio]

Why don't you need #[cfg_attr(serde_derive, derive(Serialize)]?

That's fine for me.

@Eijebong did you manage to take a look at this? Mostly as a sanity check.

[Eijebong]

From a quick look it seemed fine. We're running into dtolnay/proc-macro2#60 a lot though

[emilio]

Err, my above comment meant to quote:

it's enough to keep which on 1.x in order to avoid triggering that bug in cargo.

So @ignatenkobrain I have no preference on landing this as is or with which kept at 1.0. If the latter makes things easier, let me know and I'll remove it from the PR.

[ignatenkobrain]

IIUC, if you push this as is, you would have problems with doing cargo install from users because when compiler is updated, binary would be broken.

@cuviper, did i describe problem correctly?

[cuviper]

IIUC, if you push this as is, you would have problems with doing cargo install from users because when compiler is updated, binary would be broken.

This, but also problems if the user tries to run bindgen with a different toolchain active. e.g. having compiled bindgen with your default-stable rustc, then using it in one of your projects on nightly. Or vice versa. Any scenario where the bindgen gets linked to rustc shared libraries will mean your installation is tied to that exact toolchain.

This arises from which 2.0 -> failure -> failure_derive -> ... proc-macro2, forcing you into linking libproc_macro even though bindgen wanted it without default features. which 1.x didn't use failure at all.

[cuviper]

With harryfei/which-rs#9 in which 2.0.1, the proc-macro feature will be avoided.

[Eijebong]

:party:

[bors-servo]

☔ The latest upstream changes (presumably #1453) made this pull request unmergeable. Please resolve the merge conflicts.

[emilio]

Ok, so I rebased this, and bumped which as well. Assuming this is green I'll merge. Thanks everyone for all the effort, specially @Eijebong :)